build: fix master version helm values replacement #13877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galexrt
force-pushed
the
make_helm_chart_fix_master
branch
2 times, most recently
from
824b28b
to
83d34d7
Compare
travisn
reviewed
Mar 5, 2024
deploy/charts/rook-ceph/values.yaml
Outdated
| # @default -- `master` | ||
| tag: master | ||
| # @default -- `"master"` | ||
| tag: "master" |
There was a problem hiding this comment.
Instead of changing the script, what if we just update the ceph links to the latest links? The master links are anyway outdated and we should be using latest. Then there is no risk or need to test the change to the build script.
galexrt
force-pushed
the
make_helm_chart_fix_master
branch
from
83d34d7
to
c8434d5
Compare
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
galexrt
force-pushed
the
make_helm_chart_fix_master
branch
from
c8434d5
to
6f61f46
Compare
subhamkrai
added a commit
that referenced
this pull request
Mar 6, 2024
build: fix master version helm values replacement (backport #13877)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved by this Pull Request:
Resolves #13872
Checklist: