Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update the release version to v1.13.6 #13897

Merged
merged 1 commit into from Mar 7, 2024

Conversation

travisn
Copy link
Member

@travisn travisn commented Mar 7, 2024

For the patch release update the docs and example manifests to v1.13.6.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

For the patch release update the docs and example manifests
to v1.13.6.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Copy link

mergify bot commented Mar 7, 2024

Hi @travisn, this pull request was opened against a release branch, is it expected? Normally patches should go in the master branch first and then be backported to release branches.

@@ -7,7 +7,7 @@ image:
repository: rook/ceph
# -- Image tag
# @default -- `master`
tag: master
tag: v1.13.6
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to #13843 let's set the tag with the release version PR. Even though the release script was updating it for the official helm release, users are still having a problem with this tag when using this as the base template for their values override file.

@travisn travisn merged commit b9284ac into rook:release-1.13 Mar 7, 2024
51 of 52 checks passed
@travisn travisn deleted the release-1.13.6 branch March 7, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants