exporter: applying labels from monitoring section to ceph-exporter #13902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the labels listed under the 'monitoring' section are currently only being applied to the rook-ceph-mgr ServiceMonitor. This change extends those labels to also include the rook-ceph-exporter ServiceMonitor. Fixes: rook#13774 Signed-off-by: Redouane Kachach <rkachach@redhat.com>
travisn
reviewed
Mar 8, 2024
rkachach
force-pushed
the
fix_issue_13774
branch
2 times, most recently
from
be98ecc
to
1f7299c
Compare
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
rkachach
force-pushed
the
fix_issue_13774
branch
from
9d2bd89
to
ab5b269
Compare
travisn
approved these changes
Mar 12, 2024
subhamkrai
approved these changes
Mar 13, 2024
6 tasks
travisn
added a commit
that referenced
this pull request
Mar 13, 2024
exporter: applying labels from monitoring section to ceph-exporter (backport #13902)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the labels listed under the 'monitoring' section are currently only being applied to the rook-ceph-mgr ServiceMonitor. This change extends those labels to also include the rook-ceph-exporter ServiceMonitor.
Fixes: #13774
Checklist: