operator: make CephBlockPoolRadosNamespace and CephFilesystemSubVolumeGroup get outputs more verbose #14049
Conversation
NymanRobin
force-pushed
the
crd-output-enhancements
branch
from
f545682
to
c753b13
Compare
|
Did assume that Distributed was the default based on PinCephFSSubVolumeGroup function, with this information I also did slight change to validatePinningValues as they were a bit contradicting, let me know in case there was some misunderstanding here on my part. Other than that I was not exactly sure if pinningType, pinningConfig or pinningSetting would best describe the field. |
NymanRobin
force-pushed
the
crd-output-enhancements
branch
from
c753b13
to
b60f1df
Compare
| if !(*pinning.Distributed == 1) && !(*pinning.Distributed == 0) { | ||
| err = errors.Errorf("validate pinning type failed, Distributed: unknown value %d", *pinning.Distributed) | ||
| if *pinning.Distributed != 0 && *pinning.Distributed != 1 { | ||
| return fmt.Errorf("validate pinning type failed, Distributed: value must be 0 or 1, got %d", *pinning.Distributed) |
There was a problem hiding this comment.
The changes look equivalent to me in this method. @parth-gr Any concerns?
There was a problem hiding this comment.
I think no need for the change unless it improves anything,
And with the updated change,
we look for this only if the config is correct, but this is the first priority to be check.
if numNils > 1 {
return fmt.Errorf("only one can be set")
}
There was a problem hiding this comment.
Okay, I see so earlier returning is disabled by choice as this error should have priority makes sense, thanks for explanation @parth-gr! Okay, then I will just adjust the error message that has the 1.1 instead of 1.0
NymanRobin
force-pushed
the
crd-output-enhancements
branch
from
b60f1df
to
1e65dec
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. @NymanRobin please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork |
|
Thanks for the comments @travisn was a bit unsure how to name the pinning field but let's go with just pinning :) |
NymanRobin
force-pushed
the
crd-output-enhancements
branch
from
1e65dec
to
8aa89dd
Compare
NymanRobin
force-pushed
the
crd-output-enhancements
branch
3 times, most recently
from
ace1384
to
aed6a1f
Compare
The following printcolumns were added CephBlockPoolRadosNamespace: Phase, BlockPoolName, Age CephFilesystemSubVolumeGroup: Phase, FilesystemName, PinningConfig, Age Also improved the error messages in SubVolumeGroupClient Signed-off-by: NymanRobin <nyman.robin@gmail.com>
NymanRobin
force-pushed
the
crd-output-enhancements
branch
from
aed6a1f
to
70a7e61
Compare
operator: make CephBlockPoolRadosNamespace and CephFilesystemSubVolumeGroup get outputs more verbose (backport #14049)
The following printcolumns were added
CephBlockPoolRadosNamespace: Phase, BlockPool, Age
CephFilesystemSubVolumeGroup: Filesystem, Quota, Pinning
Related to issue: #13775