Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pool: Return error if device class update fails #14057

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

pool: Return error if device class update fails #14057

wants to merge 2 commits into from

Commits on May 31, 2024

  1. pool: return error if device class update fails 

    Updating the device class swallowed any error if updated
for the pool. The error was not even logged, so we couldn't
troubleshoot why the new crush rule was not applied.
Log the error for troubleshooting and also fail the pool
reconcile since the desired configuration was not applied.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
    @travisn
    travisn committed May 31, 2024
    Configuration menu
    Copy the full SHA
    4c6e77e View commit details
    Browse the repository at this point in the history

  2. pool: include error output in ceph command results 

    The ceph command prints errors to stderr and is being ignored
by failures in most of the pool commands, which makes
troubleshooting difficult when there is a failure. Include the
output now for all the pool commands in case of failure.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
    @travisn
    travisn committed May 31, 2024
    Configuration menu
    Copy the full SHA
    40d0bdc View commit details
    Browse the repository at this point in the history