Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: load cluster owner info in LoadClusterInfo #14079

Merged

Commits on Apr 16, 2024

  1. operator: load cluster owner info in LoadClusterInfo

    The CreateOrLoadClusterInfo (and therefore LoadClusterInfo) methods were
    not loading the ClusterInfo.OwnerInfo. This should help future CRD
    controllers get the full ClusterInfo struct without having missing
    information. Current controllers that need ClusterInfo fill the field
    themselves.
    
    During testing, I observed one corner case where an upgraded cluster was
    missing the `rook-ceph-csi-config` configmap. The cluster had a
    CephFilesystemSubVolumeGroup resource created, and the reconcile for
    that resource was attempting to create the missing CSI configmap and
    failing with a nil pointer exception due to the missing OwnerInfo field
    in ClusterInfo. This cluster condition hasn't been reproduced in healthy
    environments, and it is unknown how the CSI configmap came to be
    missing. However, the case did expose the missing loaded info as a
    potential for causing nil pointer exceptions during corner cases when
    code is otherwise correct.
    
    Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
    BlaineEXE committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    bd9447e View commit details
    Browse the repository at this point in the history