Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd: reduce safe-to-destroy retry timeout to 15s #14257

Merged
merged 1 commit into from
May 28, 2024
Merged

osd: reduce safe-to-destroy retry timeout to 15s #14257

merged 1 commit into from
May 28, 2024

Conversation

bdowling
Copy link
Contributor

@bdowling bdowling commented May 23, 2024 •
edited
Loading

This reduces the safe-to-remove retry interval from 1m to 15s.

Closes #14247

Issue resolved by this Pull Request:
Resolves #14247

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@bdowling bdowling force-pushed the pr-reduce-purge-retry-timeout branch 3 times, most recently from 1619704 to abb9deb Compare May 23, 2024 06:50
@bdowling bdowling changed the title ceph/osd/remove: reduce retry timeout to 15s osd: ceph/osd/remove, reduce retry timeout to 15s May 23, 2024
subhamkrai
subhamkrai previously requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the commit title to osd: reduce retry timeout to 15s

@travisn
Copy link
Member

travisn commented May 23, 2024

update the commit title to osd: reduce retry timeout to 15s

How about this? osd: reduce safe-to-destroy retry timeout to 15s

@bdowling bdowling force-pushed the pr-reduce-purge-retry-timeout branch from abb9deb to 62ccc77 Compare May 23, 2024 20:52
@bdowling
Copy link
Contributor Author

osd: reduce safe-to-destroy retry timeout to 15s

Ok, Done. fwiw, some of the checks failing look like they have nothing to do with my simple change..

@bdowling bdowling changed the title osd: ceph/osd/remove, reduce retry timeout to 15s osd: reduce safe-to-destroy retry timeout to 15s May 23, 2024
@travisn
Copy link
Member

travisn commented May 23, 2024

osd: reduce safe-to-destroy retry timeout to 15s

Ok, Done. fwiw, some of the checks failing look like they have nothing to do with my simple change..

Agreed, they are unrelated
@subhamkrai Could you take a look at the codespell errors in a separate PR when you get a chance?

@subhamkrai
Copy link
Contributor

osd: reduce safe-to-destroy retry timeout to 15s

Ok, Done. fwiw, some of the checks failing look like they have nothing to do with my simple change..

Agreed, they are unrelated @subhamkrai Could you take a look at the codespell errors in a separate PR when you get a chance?

here is the pr #14266

@subhamkrai
Copy link
Contributor

@Mergifyio rebase

@mergify Mergify
Copy link

mergify bot commented May 27, 2024

rebase

❌ Unable to rebase: user subhamkrai is unknown.

Please make sure subhamkrai has logged in Mergify dashboard.

subhamkrai
subhamkrai reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdowling please rebase the pr to get green CI. Thanks

@bdowling bdowling force-pushed the pr-reduce-purge-retry-timeout branch from 62ccc77 to 74303ce Compare May 27, 2024 17:51
@mergify Mergify
Copy link

mergify bot commented May 27, 2024

This pull request has merge conflicts that must be resolved before it can be merged. @bdowling please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork

@bdowling
osd: reduce safe-to-destroy retry timeout to 15s
ef0ed93 
This reduces the safe-to-remove retry interval from 1m to 15s.

Closes rook#14247

Signed-off-by: Brian Dowling <bjd-dev@simplicity.net>
@bdowling bdowling force-pushed the pr-reduce-purge-retry-timeout branch from 74303ce to ef0ed93 Compare May 27, 2024 17:54
@travisn travisn dismissed subhamkrai’s stale review May 28, 2024 16:21

feedback addressed

@travisn travisn merged commit a63c896 into rook:master May 28, 2024
52 of 53 checks passed
@mergify mergify bot mentioned this pull request May 28, 2024
Merged
6 tasks
travisn added a commit that referenced this pull request May 30, 2024
@travisn
Merge pull request #14274 from rook/mergify/bp/release-1.14/pr-14257
a7c8166 
osd: reduce safe-to-destroy retry timeout to 15s (backport #14257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhamkrai subhamkrai subhamkrai left review comments

@travisn travisn travisn approved these changes

Assignees
No one assigned
Labels
backport-release-1.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propose: make the retry timeout on ceph osd remove be a configurable flag.
3 participants
@bdowling @travisn @subhamkrai