pool: get the exact deviceClass name instead of crushroot+deviceClass #14300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
reviewed
Jun 3, 2024
ideepika
force-pushed
the
wip-solve-device-class-bug
branch
from
cbc7c72
to
b9fbcfb
Compare
travisn
reviewed
Jun 4, 2024
| // this part to improve advanced crushrule support | ||
| crushRootAndDeviceClass := step.ItemName | ||
| parts := strings.Split(crushRootAndDeviceClass, "~") | ||
| deviceClass = parts[1] |
There was a problem hiding this comment.
Are there guaranteed to have two parts separated by the tilde? I didn't think so, and perhaps this is causing the CI to fail.
There was a problem hiding this comment.
thanks for the taking a look Travis, will fix it
this lead to creation of 2 crush rules because of difference in
deviceClass names:
eg:
creating a new crush rule for changed deviceClass
("default~hdd"-->"hdd") on crush rule "test-crush-bug-az-ab-4"
Signed-off-by: Deepika Upadhyay <deepika.upadhyay@clyso.com>
ideepika
force-pushed
the
wip-solve-device-class-bug
branch
from
b9fbcfb
to
ad942c6
Compare
|
closing for some fixes to avoid ci builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this lead to creation of 2 crush rules because of difference in deviceClass names:
eg:
creating a new crush rule for changed deviceClass
("default~hdd"-->"hdd") on crush rule "test-crush-bug-az-ab-4"
Checklist: