pool: get the exact deviceClass name instead of crushroot+deviceClass #14325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failures don't appear related to this PR, there is some github action issue... |
ideepika
force-pushed
the
wip-solve-device-class-bug
branch
2 times, most recently
from
4cdf5a7
to
9621a74
Compare
travisn
requested changes
Jun 12, 2024
pkg/daemon/ceph/client/pool.go
Outdated
| @@ -529,7 +529,15 @@ func extractPoolDetails(rule ruleSpec) (string, string) { | |||
| failureDomain = step.Type | |||
| } | |||
| if step.ItemName != "" { | |||
| deviceClass = step.ItemName | |||
| // we are not using crushRoot currently, remove it to | |||
There was a problem hiding this comment.
Suggested change
| // we are not using crushRoot currently, remove it to | |
| // we are not using crushRoot currently, remove it |
this lead to creation of 2 crush rules because of difference in
deviceClass names:
eg:
creating a new crush rule for changed deviceClass
("default~hdd"-->"hdd") on crush rule "test-crush-bug-az-ab-4"
Signed-off-by: Deepika Upadhyay <deepikaupadhyay01@gmail.com>
ideepika
force-pushed
the
wip-solve-device-class-bug
branch
from
9621a74
to
41116be
Compare
travisn
approved these changes
Jun 12, 2024
Merged
6 tasks
travisn
added a commit
that referenced
this pull request
Jun 13, 2024
pool: get the exact deviceClass name instead of crushroot+deviceClass (backport #14325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this lead to creation of 2 crush rules because of difference in deviceClass names:
eg:
creating a new crush rule for changed deviceClass
("default~hdd"-->"hdd") on crush rule "test-crush-bug-az-ab-4"
tested locally on changing device class hdd to nvme
Checklist: