Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: add CR flag to tune slow device class for OSD on PVC in the Cloud #4308

Merged
merged 1 commit into from Dec 16, 2019

Conversation

leseb
Copy link
Member

@leseb leseb commented Nov 13, 2019

Description of your changes:

gp2 devices present themselves as SSDs,
but have much more variable performance.
Ceph attempts to adjust some settings based on the drive type,
HDD/SSD
In this case client I/O can be impacted too much by assuming gp2 devices are like other SSDs
(an example is https://bugzilla.redhat.com/show_bug.cgi?id=1765923#c6)

In order to prevent this, rook can set the following for OSDs on gp2 devices:

osd_recovery_sleep = 0.1
osd_snap_trim_sleep = 2
osd_delete_sleep = 2

Closes: #4298 and https://bugzilla.redhat.com/show_bug.cgi?id=1771047
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #4298

Checklist:

  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.
  • Comments have been added or updated based on the standards set in CONTRIBUTING.md
  • Add the flag for skipping the CI if this PR does not require a build. See here for more details.

[test ceph]

@leseb leseb added ceph main ceph tag ceph-osd labels Nov 13, 2019
@leseb leseb requested a review from travisn November 13, 2019 14:34
pkg/operator/ceph/cluster/osd/spec.go Outdated Show resolved Hide resolved
pkg/operator/ceph/cluster/osd/spec.go Outdated Show resolved Hide resolved
@leseb leseb added this to In progress in v1.2 via automation Dec 6, 2019
@leseb leseb removed this from In progress in v1.2 Dec 6, 2019
@leseb leseb self-assigned this Dec 13, 2019
@leseb leseb changed the title ceph: osd tune startup flags when running on GP2 ceph: add CR flag to tune slow device class for OSD on PVC in the Cloud Dec 13, 2019
gp2 devices present themselves as SSDs,
but have much more variable performance.
Ceph attempts to adjust some settings based on the drive type,
HDD/SSD
In this case client I/O can be impacted too much by assuming gp2 devices are like other SSDs
(an example is https://bugzilla.redhat.com/show_bug.cgi?id=1765923#c6)

In order to prevent this, rook can set the following for OSDs
if the new CR setting `tuneSlowDeviceClass` is set to `true`:

```
osd_recovery_sleep = 0.1
osd_snap_trim_sleep = 2
osd_delete_sleep = 2
```

Closes: rook#4298 and https://bugzilla.redhat.com/show_bug.cgi?id=1771047
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb added this to In progress in v1.2 via automation Dec 16, 2019
@leseb leseb merged commit 9b6ad00 into rook:master Dec 16, 2019
v1.2 automation moved this from In progress to Done Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ceph main ceph tag ceph-osd
Projects
No open projects
v1.2
  
Done
Development

Successfully merging this pull request may close these issues.

Ability to set device class on OSDs when on PVCs
4 participants