Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfs: update documentation and example #6455

Merged
merged 1 commit into from Oct 20, 2020

Conversation

prksu
Copy link
Contributor

@prksu prksu commented Oct 19, 2020

Signed-off-by: Ahmad Nurus S prksu.sh@gmail.com
(cherry picked from commit c22189b)

Description of your changes:
We need to backport PR #6440 to release-1.4 as well

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

[skip ci]

Signed-off-by: Ahmad Nurus S <prksu.sh@gmail.com>
(cherry picked from commit c22189b)
@galexrt galexrt merged commit 9edbf47 into rook:release-1.4 Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants