ceph: always apply config flags for mds and rgw #7681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
force-pushed
the
fix-mds-flag-on-upgrade
branch
from
aac998f
to
a8da42a
Compare
We now always set the config flags on reconcile. Previously we were looking for non-existing rgw or mds which means that on upgrade we would never set those flags. However, we want to set those flags on "old" cluster that got upgraded. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
fix-mds-flag-on-upgrade
branch
from
a8da42a
to
ca1cf66
Compare
travisn
approved these changes
Apr 19, 2021
| // Unfortunately, on upgrade we would not set the flags which is not ideal for old clusters where we were no setting those flags | ||
| // The KV supports setting those flags even if the RGW is running | ||
| logger.Info("setting rgw config flags") | ||
| err = c.setDefaultFlagsMonConfigStore(rgwConfig.ResourceName) |
There was a problem hiding this comment.
Question for a separate PR if anything... Could we set these flags instead with cmd line args instead of the ceph config? Or do we need to keep them as config so they can be overridden?
There was a problem hiding this comment.
Some of the flags are sensitive so we want to keep them as config so they can be overridden.
This was referenced Apr 20, 2021
leseb
added a commit
that referenced
this pull request
Apr 20, 2021
ceph: always apply config flags for mds and rgw (backport #7681)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
We now always set the config flags on reconcile. Previously we were
looking for non-existing rgw or mds which means that on upgrade we would
never set those flags. However, we want to set those flags on "old"
cluster that got upgraded.
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.