Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump to golang version 1.16 #7945

Merged
merged 1 commit into from May 25, 2021
Merged

build: bump to golang version 1.16 #7945

merged 1 commit into from May 25, 2021

Conversation

subhamkrai
Copy link
Contributor

@subhamkrai subhamkrai commented May 19, 2021 •
edited by travisn

this commit bump to golang version 1.16.

Signed-off-by: subhamkrai srai@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #7938

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

[test]

@subhamkrai subhamkrai requested review from leseb and travisn May 19, 2021 07:50
@subhamkrai
build: bump to golang version 1.16
bf7b460 
this commit bump to golang version 1.16.

Signed-off-by: subhamkrai <srai@redhat.com>
travisn
travisn requested changes May 19, 2021
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need to wait until Jenkins is updated with 1.16, it should be done next week...

travisn
travisn approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins is running 1.16 now, let's proceed!

@travisn travisn merged commit e1b64e3 into rook:master May 25, 2021
@subhamkrai subhamkrai deleted the bump-golang1.16 branch May 25, 2021 05:22
@travisn
Copy link
Member

travisn commented Jun 2, 2021

@subhamkrai Please open a backport PR for this to release-1.6, the bot won't pick it up since it includes the actions. Thanks!

@subhamkrai
Copy link
Contributor Author

@subhamkrai Please open a backport PR for this to release-1.6, the bot won't pick it up since it includes the actions. Thanks!

I'll open PR soon.

@subhamkrai
Copy link
Contributor Author

@subhamkrai Please open a backport PR for this to release-1.6, the bot won't pick it up since it includes the actions. Thanks!

I'll open PR soon.

#8044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

@travisn travisn travisn approved these changes

@sp98 sp98 sp98 approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build with golang 1.16
4 participants
@subhamkrai @travisn @leseb @sp98