Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: parse json correctly #8000

Merged
merged 1 commit into from May 28, 2021
Merged

ceph: parse json correctly #8000

merged 1 commit into from May 28, 2021

Conversation

satoru-takeuchi
Copy link
Member

Description of your changes:

radosgw-admin may output logs before and after JSON when this command succeeds. We should get rid of these logs before unmarshaling output. Although the logs before JSON were treated in PR7354, the logs after JSON weren't.

Checklist:

  • [o] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • [o] Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • [o] Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • [o] Reviewed the developer guide on Submitting a Pull Request
  • [o] Documentation has been updated, if necessary.
  • [o] Unit tests have been added, if necessary.
  • [o] Integration tests have been added, if necessary.
  • [o] Pending release notes updated with breaking and/or notable changes, if necessary.
  • [o] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • [o] Code generation (make codegen) has been run to update object specifications, if necessary.

@satoru-takeuchi satoru-takeuchi added ceph main ceph tag ceph-rados Ceph core components / functionality backport-release-1.6 and removed ceph-rados Ceph core components / functionality labels May 27, 2021
@satoru-takeuchi
ceph: parse json correctly
ca9aa1a 
radosgw-admin may output logs before and after JSON when this command succeeds. We should
get rid of these logs before unmarshaling output. Although the logs before JSON were
treated in  PR7354, the logs after JSON weren't.

Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
leseb
leseb approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully with ceph/go-ceph#496 and #7998 we will stop using this command eventually :)

@satoru-takeuchi
Copy link
Member Author

Hopefully with ceph/go-ceph#496 and #7998 we will stop using this command eventually :)

Year, of course I know these PRs!

@satoru-takeuchi satoru-takeuchi merged commit cb7f25d into rook:master May 28, 2021
@mergify mergify bot mentioned this pull request May 28, 2021
Merged
satoru-takeuchi added a commit that referenced this pull request May 28, 2021
@satoru-takeuchi
Merge pull request #8014 from rook/mergify/bp/release-1.6/pr-8000
cbc9818 
ceph: parse json correctly (backport #8000)
@satoru-takeuchi satoru-takeuchi deleted the ceph-parse-json-correctly branch June 1, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@satoru-takeuchi @leseb