Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: ability to disable pool mirroring #8215

Merged
merged 1 commit into from Jul 5, 2021
Merged

ceph: ability to disable pool mirroring #8215

merged 1 commit into from Jul 5, 2021

Conversation

sp98
Copy link
Contributor

@sp98 sp98 commented Jun 29, 2021 •
edited

The PR disables mirroring on a pool when PoolSpec.Mirroring.Enabled
is set to false

When Mirroring.Mode == pool

  • remove cluster peer
  • disable mirroring on the pool.

When Mirroring.Mode == image

  • Add warning for the user to disable mirroring manually for the images

Stop the mirroring health checker goroutine
Reset the mirroring health check status in the CR.

Signed-off-by: Santosh Pillai sapillai@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify mergify bot added the ceph main ceph tag label Jun 29, 2021
travisn
travisn reviewed Jun 29, 2021
View reviewed changes
pkg/apis/ceph.rook.io/v1/pool.go Outdated Show resolved Hide resolved
pkg/operator/ceph/pool/controller.go Outdated Show resolved Hide resolved
@sp98 sp98 marked this pull request as ready for review July 1, 2021 12:25
@sp98 sp98 requested a review from travisn July 1, 2021 12:25
travisn
travisn reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI needs investigation

pkg/operator/ceph/pool/controller.go Outdated Show resolved Hide resolved
@travisn travisn requested a review from leseb July 1, 2021 17:18
@sp98
ceph: disable mirroring
05b0ae0 
The PR disables mirroring on a pool when PoolSpec.Mirroring.Enabled
is set to false
- disable mirroring on the pool for `Mirroring.Mode == pool`
- Add warning for the user to disable mirroring manually for `Mirroring.Mode == image`
- Stop the mirroring health checker goroutine
- Reset the mirroring health check status in the CR.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
@sp98 sp98 requested a review from travisn July 2, 2021 05:47
@leseb leseb changed the title ceph: disable mirroring ceph: ability to disable pool mirroring Jul 5, 2021
@leseb leseb merged commit d59ae25 into rook:master Jul 5, 2021
@mergify mergify bot mentioned this pull request Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

@travisn travisn Awaiting requested review from travisn

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sp98 @leseb @travisn