ceph: always rehydrate the access and secret keys #8286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to that the access and secret keys were left empty if the user already existed, which led to updating the secret with empty values when the operator restarts. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
fix-object-store-user
branch
from
baed2e1
to
863e1d3
Compare
BlaineEXE
approved these changes
Jul 9, 2021
Comment on lines
+38
to
+39
| // Somehow meta.TypeAccessor returns an empty string for the type name so using reflection instead | ||
| objType := reflect.TypeOf(obj) |
There was a problem hiding this comment.
If this is only in unit tests, that is to be expected, and I've had to manually fill this info in in the tests.
There was a problem hiding this comment.
As discussed, it was at runtime :(
leseb
force-pushed
the
fix-object-store-user
branch
from
863e1d3
to
c5c03f9
Compare
The Rados Gateway Admin OPS API has changed its behavior from Nautilus to Pacific. Calling user create on an existing user wil generate additional keys to the user on Nautilus. Where in Pacific it will report an error with UserAlreadyExists. So to handle both scenarios, let's first get the user, and if the user does not exist (NoSuchUser) we then create it. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
fix-object-store-user
branch
from
c5c03f9
to
f074c12
Compare
leseb
added a commit
that referenced
this pull request
Jul 12, 2021
ceph: always rehydrate the access and secret keys (backport #8286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Prior to that the access and secret keys were left empty if the user
already existed, which led to updating the secret with empty values when
the operator restarts.
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.