ceph: update rook-ceph-mgr-cluster role rules to include PV and SC #8347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
Jul 20, 2021
| @@ -304,6 +305,14 @@ rules: | |||
| - list | |||
| - get | |||
| - watch | |||
| - apiGroups: | |||
| - "storage.k8s.io" | |||
There was a problem hiding this comment.
nit: quotes shouldn't be needed
Suggested change
| - "storage.k8s.io" | |
| - storage.k8s.io |
travisn
requested changes
Jul 21, 2021
josephsawaya
force-pushed
the
rook-ceph-mgr-role-changes
branch
from
26c741c
to
23057b7
Compare
leseb
reviewed
Jul 23, 2021
leseb
requested changes
Jul 23, 2021
Since we changed the Rook orchestrator module for Ceph, it now has to access Storage Classes and Persistent Volumes in the cluster to gather inventory and create OSDs so we have to make changes to the rook-ceph-mgr-cluster role so the orchestrator has permission to access these resources. Signed-off-by: Joseph Sawaya <jsawaya@redhat.com>
josephsawaya
force-pushed
the
rook-ceph-mgr-role-changes
branch
from
23057b7
to
1ddc390
Compare
leseb
approved these changes
Jul 27, 2021
travisn
approved these changes
Jul 27, 2021
travisn
added a commit
that referenced
this pull request
Jul 27, 2021
ceph: update rook-ceph-mgr-cluster role rules to include PV and SC (backport #8347)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Since we changed the Rook orchestrator module for Ceph, it now has to access Storage Classes and Persistent Volumes in the cluster to gather inventory and create OSDs so we have to make changes to the rook-ceph-mgr-cluster role so the orchestrator has permission to access these resources.
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.