Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Promote the build with tag suffix if needed #8390

Merged
merged 1 commit into from
Jul 26, 2021
Merged

build: Promote the build with tag suffix if needed #8390

merged 1 commit into from
Jul 26, 2021

Conversation

travisn
Copy link
Member

@travisn travisn commented Jul 26, 2021

Description of your changes:
The beta releases should have the tag suffix included in the helm chart and release version tags.

The v1.7.0-beta.0 promote step failed due to the suffix being stripped from the desired version.

Which issue is resolved by this Pull Request:
Resolves #8378

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@travisn
build: promote the build with tag suffix if needed
a1d37b4 
The beta releases should have the tag suffx included in
the helm chart and release version tags.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn travisn requested a review from BlaineEXE July 26, 2021 23:28
@travisn travisn merged commit 778726f into rook:release-1.7 Jul 26, 2021
@travisn travisn deleted the promote-with-tag-suffix branch February 24, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlaineEXE BlaineEXE BlaineEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travisn @BlaineEXE