ceph: do not check ok-to-stop when OSDs are in CLBO #8583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlaineEXE
reviewed
Aug 24, 2021
This handles the scenario where the OSDs have been created but not yet started due to a wrong CR configuration. For instance, when OSDs are encrypted and Vault is used to store encryption keys, if the KV version is incorrect during the cluster initialization the OSDs will fail to start and stay in CLBO until the CR is updated again with the correct KV version so that it can start. For this scenario, if the CRUSH map has no host registered yet it's fair to assume the initialization broke and we need to fix it. So when don't need to call ok-to-stop since it will always fail and eventually force pass but let's not wait for nothing. Signed-off-by: Sébastien Han <seb@redhat.com>
travisn
approved these changes
Aug 25, 2021
BlaineEXE
approved these changes
Aug 25, 2021
This was referenced Aug 25, 2021
travisn
added a commit
that referenced
this pull request
Aug 26, 2021
ceph: do not check ok-to-stop when OSDs are in CLBO (backport #8583)
travisn
added a commit
that referenced
this pull request
Aug 26, 2021
ceph: do not check ok-to-stop when OSDs are in CLBO (backport #8583)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This handles the scenario where the OSDs have been created but not yet
started due to a wrong CR configuration.
For instance, when OSDs are encrypted and Vault is used to store
encryption keys, if the KV version is incorrect during the cluster
initialization the OSDs will fail to start and stay in CLBO until the
CR is updated again with the correct KV version so that it can start.
For this scenario, if the CRUSH map has no host registered yet it's fair
to assume the initialization broke and we need to fix it. So when don't
need to call ok-to-stop since it will always fail and eventually force
pass but let's not wait for nothing.
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.