Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: fix vault kv secret engine auto-detection #8618

Merged
merged 1 commit into from
Aug 31, 2021
Merged

ceph: fix vault kv secret engine auto-detection #8618

merged 1 commit into from
Aug 31, 2021

Commits on Aug 31, 2021

  1. ceph: fix vault kv secret engine auto-detection 

    Passing struct by value essentially gives you a copy, so when modified
within a function, the scope is then reduced to that function. Using
pointers solves that you mutate the struct as many times as you want from
anywhere.
As a result, the auto-detection of the Vault KV backend was not working
correctly.
Also, added a ton of unit tests for Vault.

Signed-off-by: Sébastien Han <seb@redhat.com>
    @leseb
    leseb committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    d675969 View commit details
    Browse the repository at this point in the history