ceph: fix CephMonQuorumAtRisk Alert Query #8652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parth-gr
reviewed
Sep 7, 2021
cluster/examples/kubernetes/ceph/monitoring/prometheus-ceph-v14-rules.yaml
Show resolved
Hide resolved
The updated query will work for single mon deployment and will work better for deployments with five or more mons. Signed-off-by: Anmol Sachan <anmol13694@gmail.com>
anmolsachan
force-pushed
the
fix_cephMonQuorumAtRisk
branch
from
4ae6948
to
a1efcd7
Compare
subhamkrai
reviewed
Sep 7, 2021
| @@ -80,7 +80,7 @@ spec: | |||
| severity_level: error | |||
| storage_type: ceph | |||
| expr: | | |||
| count(ceph_mon_quorum_status{job="rook-ceph-mgr"} == 1) <= ((count(ceph_mon_metadata{job="rook-ceph-mgr"}) % 2) + 1) | |||
| count(ceph_mon_quorum_status{job="rook-ceph-mgr"} == 1) <= (floor(count(ceph_mon_metadata{job="rook-ceph-mgr"}) / 2) + 1) | |||
There was a problem hiding this comment.
@travisn @anmolsachan recently, we allowed having even mons too, is this something we need to handle here?
There was a problem hiding this comment.
This formula should also work for an even number of mons.
travisn
approved these changes
Sep 7, 2021
| @@ -80,7 +80,7 @@ spec: | |||
| severity_level: error | |||
| storage_type: ceph | |||
| expr: | | |||
| count(ceph_mon_quorum_status{job="rook-ceph-mgr"} == 1) <= ((count(ceph_mon_metadata{job="rook-ceph-mgr"}) % 2) + 1) | |||
| count(ceph_mon_quorum_status{job="rook-ceph-mgr"} == 1) <= (floor(count(ceph_mon_metadata{job="rook-ceph-mgr"}) / 2) + 1) | |||
There was a problem hiding this comment.
This formula should also work for an even number of mons.
leseb
added a commit
that referenced
this pull request
Sep 8, 2021
ceph: fix CephMonQuorumAtRisk Alert Query (backport #8652)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated query will work for single mon deployment and will work better for deployments with five or more mons.
Signed-off-by: Anmol Sachan anmol13694@gmail.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #8156
Checklist:
make codegen) has been run to update object specifications, if necessary.[skip ci]