Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: run operator with rook user #8744

Merged
merged 1 commit into from
Nov 5, 2021
Merged

core: run operator with rook user #8744

merged 1 commit into from
Nov 5, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Sep 17, 2021

Description of your changes:

The rook operator as well as the toolbox pod run with the "rook" user
with UID 2016. The UID was chosen based on the year of the initial
commit in the rook/rook repository.
No more root user running.

Closes: #8734
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #8734

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@mergify mergify bot added the ceph main ceph tag label Sep 17, 2021
travisn
travisn requested changes Sep 17, 2021
View reviewed changes
images/ceph/Dockerfile Show resolved Hide resolved
images/ceph/Dockerfile Show resolved Hide resolved
@leseb leseb requested a review from travisn September 22, 2021 15:11
@leseb leseb force-pushed the fix-8734 branch 2 times, most recently from 433ff0e to ff481b6 Compare September 22, 2021 16:26
@leseb
Copy link
Member Author

leseb commented Sep 22, 2021

@BlaineEXE @travisn This will have to wait for Flex to be removed I'm afraid, the driver requires root all over the place.

@travisn
Copy link
Member

travisn commented Sep 22, 2021

@BlaineEXE @travisn This will have to wait for Flex to be removed I'm afraid, the driver requires root all over the place.

Time to remove the flex driver in master then, right? This is already planned for 1.8 and likely won't cause many backport conflicts.

@leseb
Copy link
Member Author

leseb commented Sep 23, 2021

@BlaineEXE @travisn This will have to wait for Flex to be removed I'm afraid, the driver requires root all over the place.

Time to remove the flex driver in master then, right? This is already planned for 1.8 and likely won't cause many backport conflicts.

Alt Text

@mergify
Copy link

mergify bot commented Sep 24, 2021

This pull request has merge conflicts that must be resolved before it can be merged. @leseb please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@leseb leseb force-pushed the fix-8734 branch 7 times, most recently from 9745ef0 to e104332 Compare September 24, 2021 16:12
@mergify
Copy link

mergify bot commented Sep 27, 2021

This pull request has merge conflicts that must be resolved before it can be merged. @leseb please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@leseb leseb force-pushed the fix-8734 branch 2 times, most recently from 0641fe6 to afb49b8 Compare September 28, 2021 14:02
@leseb leseb added this to In progress in v1.8 via automation Sep 28, 2021
@leseb leseb removed this from In progress in v1.8 Sep 28, 2021
@mergify
Copy link

mergify bot commented Oct 8, 2021

This pull request has merge conflicts that must be resolved before it can be merged. @leseb please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@leseb leseb force-pushed the fix-8734 branch 2 times, most recently from edaaa74 to fe48023 Compare November 4, 2021 17:16
@mergify
Copy link

mergify bot commented Nov 4, 2021

This pull request has merge conflicts that must be resolved before it can be merged. @leseb please rebase it. https://rook.io/docs/rook/latest/development-flow.html#updating-your-fork

@leseb leseb force-pushed the fix-8734 branch 6 times, most recently from 6835ee5 to bd048fe Compare November 5, 2021 15:17
@leseb
core: run operator with rook user
d06a6f9 
The rook operator as well as the toolbox pod run with the "rook" user
with UID 2016. The UID was chosen based on the year of the initial
commit in the rook/rook repository.
No more root user running.

Closes: rook#8734
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb merged commit 3b85de4 into rook:master Nov 5, 2021
@leseb leseb deleted the fix-8734 branch November 5, 2021 16:56
@leseb leseb changed the title ceph: run operator with rook user core: run operator with rook user Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@BlaineEXE BlaineEXE BlaineEXE approved these changes

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: run rook-operator and toolbox with non-root user
3 participants
@leseb @travisn @BlaineEXE