Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix multisite test #8785

Merged
merged 1 commit into from
Sep 22, 2021
Merged

ci: fix multisite test #8785

merged 1 commit into from
Sep 22, 2021

Conversation

leseb
Copy link
Member

@leseb leseb commented Sep 22, 2021

Description of your changes:

We just need to wait a little for the object to be replicated to the
other gateway. A simple retry solves this.

Closes: #8671
Signed-off-by: Sébastien Han seb@redhat.com

Which issue is resolved by this Pull Request:
Resolves #8671

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@leseb
ci: fix multisite test
7c8dc4b 
We just need to wait a little for the object to be replicated to the
other gateway. A simple retry solves this.

Closes: rook#8671
Signed-off-by: Sébastien Han <seb@redhat.com>
subhamkrai
subhamkrai approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just to confirm you restarted the test a few times to confirm?

@leseb
Copy link
Member Author

leseb commented Sep 22, 2021

LGTM, just to confirm you restarted the test a few times to confirm?

No but I confirmed the behavior from a live runner. Let's see if I can get a repro by restarting though

@leseb leseb merged commit e8d540c into rook:master Sep 22, 2021
@leseb leseb deleted the fix-multisite branch September 22, 2021 13:39
@leseb leseb added the ci label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@subhamkrai subhamkrai subhamkrai approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI fails intermittently on rgw multi-site test
3 participants
@leseb @travisn @subhamkrai