ci: fix the test name for upgrade suite #8848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we were pointing at CephUpgradeSuite test only this was running all the tests and thus some resources were created by other tests. Let's just run the test we need. Closes: rook#8843 Signed-off-by: Sébastien Han <seb@redhat.com>
|
@Mergifyio rebase |
|
Command
|
sp98
reviewed
Sep 28, 2021
| @@ -194,7 +194,7 @@ jobs: | |||
| - name: TestCephUpgradeSuite | |||
| run: | | |||
| export DEVICE_FILTER=$(lsblk|awk '/14G/ {print $1}'| head -1) | |||
| go test -v -timeout 1800s -run CephUpgradeSuite github.com/rook/rook/tests/integration | |||
| go test -v -timeout 1800s -run CephUpgradeSuite/TestUpgradeRookToMaster github.com/rook/rook/tests/integration | |||
There was a problem hiding this comment.
(asking for my understanding) Why do we want to run only RookToMaster upgrade tests and not the other ceph upgrade tests in this suite?
There was a problem hiding this comment.
Because the other tests are run on a daily basis (nightly jobs) and this one runs on PRs and release.
sp98
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Since we were pointing at CephUpgradeSuite test only this was running
all the tests and thus some resources were created by other tests.
Let's just run the test we need.
Closes: #8843
Signed-off-by: Sébastien Han seb@redhat.com
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.