build: start tracking rbac generated from helm chart #8878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
reviewed
Sep 29, 2021
BlaineEXE
force-pushed
the
initial-generate-rbac-from-helm
branch
9 times, most recently
from
6603fd1
to
fc2edf9
Compare
This is a starting step to be able to generate common.yaml from Helm charts. For right now, we merely want to be able to determine when the rendered output of the Helm chart changes. Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
BlaineEXE
force-pushed
the
initial-generate-rbac-from-helm
branch
from
fc2edf9
to
e2ba16f
Compare
travisn
reviewed
Sep 30, 2021
| @@ -0,0 +1,1239 @@ | |||
| kind: ClusterRole | |||
There was a problem hiding this comment.
Other generated resources like crds.yaml are just generated directly to the location where they are needed such as the examples folder. Perhaps in a future PR, will this be directly generated directly to common.yaml?
There was a problem hiding this comment.
That's the idea. For now I want to have some room to modify the helm charts and massage things into place in smaller PRs, then start generating common.yaml once things are in good shape rather than trying to change too much at once.
travisn
approved these changes
Sep 30, 2021
|
@BlaineEXE, A question, I need to explicitly install this dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a starting step to be able to generate common.yaml from Helm
charts. For right now, we merely want to be able to determine when the
rendered output of the Helm chart changes.
Signed-off-by: Blaine Gardner blaine.gardner@redhat.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.