New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Add appVersion property to the charts #9051
Conversation
cluster/charts/library/Chart.yaml
Outdated
@@ -2,6 +2,7 @@ apiVersion: v2 | |||
name: library | |||
description: A simple library chart to share content between Rook's charts | |||
version: 0.0.1 | |||
appVersion: 0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this for the library? It's not a top-level chart that contains any app but a library of reusable teplates, so I think maybe this is best left out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, not necessary for the library, was just mirroring the version
property. I'll remove it.
icon: https://rook.io/images/rook-logo.svg | ||
sources: | ||
- https://github.com/rook/rook | ||
dependencies: | ||
- name: library | ||
version: "0.0.1" | ||
appVersion: "0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to specify the app version for the dependency. It isn't present for the rook-ceph
chart I see below.
The appVersion should be set to the version of the application. Since the helm charts are built by Rook in the same release version as Rook itself, the version and appVersion values will be the same. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
d734abd
to
bffe99c
Compare
helm: Add appVersion property to the charts (backport #9051)
Description of your changes:
The appVersion should be set to the version of the application. Since the helm charts are built by Rook in the same release version as Rook itself, the version and appVersion values will be the same.
Which issue is resolved by this Pull Request:
Resolves #3589
Checklist:
make codegen
) has been run to update object specifications, if necessary.