Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: update comments to match the default image in the code #9233

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

arugal
Copy link
Contributor

@arugal arugal commented Nov 24, 2021

Description of your changes:

Change the default image in value.yaml to match spec.go

Signed-off-by: zhangwei zhangwei24@apache.org

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@Madhu-1
Copy link
Member

Madhu-1 commented Nov 24, 2021

@arugal can you please fix commitlint issue

update comments to match the default image in the code.

Signed-off-by: zhangwei <zhangwei24@apache.org>
@arugal
Copy link
Contributor Author

arugal commented Nov 24, 2021

@arugal can you please fix commitlint issue

fixed :)

@leseb leseb merged commit 12638cb into rook:master Nov 24, 2021
@arugal arugal deleted the typo branch November 24, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants