docs: add instructions to upgrade admission controller #9372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
requested changes
Dec 9, 2021
Documentation/ceph-upgrade.md
Outdated
| kubectl apply -f deploy/examples/monitoring/rbac.yaml | ||
| ``` | ||
|
|
||
| * [Admission controller](admission-controller-usage.md): The admission controller has been |
There was a problem hiding this comment.
Should this be part of step 3 where the operator is updated? This is inside step 1 where the RBAC and CRDs are updated.
There was a problem hiding this comment.
I think it's fine to do it here. It is an optional resource, and so there is already a section for it. A user could get mixed up an accidentally skip step 2, but that step is also optional of a sort, so I'm not terribly worried about it breaking things.
BlaineEXE
force-pushed
the
upgrade-doc-admission-controller
branch
2 times, most recently
from
4cf6d3f
to
fb1c0a0
Compare
10 tasks
travisn
requested changes
Dec 9, 2021
Documentation/ceph-upgrade.md
Outdated
| there are additional updates. The admission controller has been integrated inside the operator | ||
| instead of a separate deployment. This means that the webhook server certificates are now stored in | ||
| the operator, and the operator manifest must be updated to use the one provided in | ||
| `deploy/examples/operator.yaml`. If you are using Helm to manage the deployment there is nothing to |
There was a problem hiding this comment.
Suggested change
| `deploy/examples/operator.yaml`. If you are using Helm to manage the deployment there is nothing to | |
| `deploy/examples/operator.yaml`. If you are using Helm to manage the deployment this handled automatically. |
Documentation/ceph-upgrade.md
Outdated
| @@ -340,6 +340,24 @@ When the operator is updated, it will proceed to update all of the Ceph daemons. | |||
| kubectl -n $ROOK_OPERATOR_NAMESPACE set image deploy/rook-ceph-operator rook-ceph-operator=rook/ceph:v1.8.0 | |||
| ``` | |||
|
|
|||
| #### Admission controller | |||
| At the same time, if you use the optional [Admission controller](admission-controller-usage.md), | |||
There was a problem hiding this comment.
Suggested change
| At the same time, if you use the optional [Admission controller](admission-controller-usage.md), | |
| If you enabled the optional [Admission controller](admission-controller-usage.md), |
Documentation/ceph-upgrade.md
Outdated
| do. | ||
|
|
||
| When updating the operator deployment with the latest example from Rook, there is some risk of | ||
| overwriting changes you have made to the deployment or to the `rook-ceph-operator-config` ConfigMap. |
There was a problem hiding this comment.
Suggested change
| overwriting changes you have made to the deployment or to the `rook-ceph-operator-config` ConfigMap. | |
| overwriting changes if you have customized the operator deployment or the `rook-ceph-operator-config` ConfigMap. |
In 1.8, the admission controller has merged with the operator and the operator needs an emptyDir and a volume mount to store the webhook certificates. Co-authored-by: Blaine Gardner <blaine.gardner@redhat.com> Co-authored-by: Sébastien Han <seb@redhat.com> Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
BlaineEXE
force-pushed
the
upgrade-doc-admission-controller
branch
from
fb1c0a0
to
6c09de6
Compare
travisn
approved these changes
Dec 9, 2021
BlaineEXE
added a commit
that referenced
this pull request
Dec 9, 2021
docs: add instructions to upgrade admission controller (backport #9372)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.8, the admission controller has merged with the operator and the
operator needs an emptyDir and a volume mount to store the webhook
certificates.
Co-authored-by: Blaine Gardner blaine.gardner@redhat.com
Co-authored-by: Sébastien Han seb@redhat.com
Signed-off-by: Blaine Gardner blaine.gardner@redhat.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.