Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update release version to v1.8.2 #9538

Merged
merged 1 commit into from Jan 6, 2022
Merged

build: Update release version to v1.8.2 #9538

merged 1 commit into from Jan 6, 2022

Conversation

travisn
Copy link
Member

@travisn travisn commented Jan 6, 2022

Description of your changes:
With the patch release the examples and docs are updated to v1.8.2

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@travisn
build: update release version to v1.8.2
ecb9162 
With the patch release the examples and docs are updated to v1.8.2

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn travisn requested a review from leseb January 6, 2022 17:17
@mergify
Copy link

mergify bot commented Jan 6, 2022

Hi @travisn, this pull request was opened against a release branch, is it expected? Normally patches should go in the master branch first and then be backported to release branches.

leseb
leseb approved these changes Jan 6, 2022
View reviewed changes
.github/workflows/canary-integration-test.yml
@@ -86,7 +86,7 @@ jobs:
sed -i 's/<OSD-IDs>/1/' deploy/examples/osd-purge.yaml
# the CI must force the deletion since we use replica 1 on 2 OSDs
sed -i 's/false/true/' deploy/examples/osd-purge.yaml
sed -i 's|rook/ceph:v1.8.1|rook/ceph:local-build|' deploy/examples/osd-purge.yaml
sed -i 's|rook/ceph:v1.8.2|rook/ceph:local-build|' deploy/examples/osd-purge.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we should remove this and use a regex so that we don't have to modify the line every time :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@travisn travisn merged commit 8b02ee5 into rook:release-1.8 Jan 6, 2022
@travisn travisn deleted the release-1.8.2 branch January 6, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travisn @leseb