object: set default zone/zonegroup/realm values for external rgw #9751
Conversation
thotz
force-pushed
the
set-default-for-zone-zonegroup-external-rgw
branch
from
1009345
to
f3a2361
Compare
thotz
force-pushed
the
set-default-for-zone-zonegroup-external-rgw
branch
from
f3a2361
to
056515d
Compare
thotz
force-pushed
the
set-default-for-zone-zonegroup-external-rgw
branch
from
056515d
to
78e32f8
Compare
| * the object context fields. | ||
| */ | ||
|
|
||
| return "", "default", "default", nil |
There was a problem hiding this comment.
How does this affect pre-existing CephObjectStores that were created with zone/zonegroup having the name of the store?
There was a problem hiding this comment.
@BlaineEXE : The change is applicable only for external ceph clusters with rgw servers running on them, not with the internal cluster in which zone/zonegroup/realm created with name of cephobjectstore. IMO most of the users either create zone/zonegroup/realm with a different name than the name of the ceph object store(since the zone is a kinda collection of cephobject stores make sense to use a different name) or go with none. It is very rare to have users have the same name as cephobjectstore. If the are multiple zone/zonegroup/realm exists the plan is to fix them cleanly by supporting #6342.
There was a problem hiding this comment.
If you say the breaking case is rare, it seems unlikely that we will have any users experience breakage on upgrade to v1.9. In the case of any breakages, we will rely on you to debug those issues at such time.
currently if multisite is not configured Rook sets values for zone/zonegroup/realm as object store name which is only valid for internal ceph object store. This may not exists for rgw running in external cluster. Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
thotz
force-pushed
the
set-default-for-zone-zonegroup-external-rgw
branch
from
78e32f8
to
022645f
Compare
currently if multisite is not configured Rook sets values for
zone/zonegroup/realm as object store name which is only valid for
internal ceph object store. This may not exists for rgw running in
external cluster.
Signed-off-by: Jiffin Tony Thottan thottanjiffin@gmail.com
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.