Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Perl regexp instead of grep extended #70

Closed
bubalush opened this issue Sep 10, 2020 · 6 comments
Closed

Add support Perl regexp instead of grep extended #70

bubalush opened this issue Sep 10, 2020 · 6 comments

Comments

@bubalush
Copy link

bubalush commented Sep 10, 2020

There is no way how to find changes with the following regexp:
^(?!test).*

@bubalush
Copy link
Author

I suggest changing grep -i -E to grep -i -P

@roopakv
Copy link
Owner

roopakv commented Sep 10, 2020

@bubalush thank you for the issue, could you point to the command you are referring to?

@bubalush
Copy link
Author

bubalush commented Sep 11, 2020

For example https://github.com/roopakv/orbs/blob/master/src/commands/trigger_pipeline_if_modified.yml#L73.
If you can change it everywhere in your orb, it will be great.

Grep extended regexp doesn't support all functions. grep -P is the same as pcregrep - a grep with Perl-compatible regular expressions.

I'm trying to find changes everywhere except test folder = ^(?!test).* to trigger the main workflow.

@roopakv
Copy link
Owner

roopakv commented Sep 11, 2020

@bubalush i think the one thing i want to look into is backward compatibility. otherwise i think should be ok

@bubalush
Copy link
Author

Great, thanks in advance. I believe that it will bring more flexibility to your orbs.

adsr added a commit to adsr/orbs that referenced this issue Oct 17, 2020
roopakv pushed a commit that referenced this issue Oct 26, 2020
* Support custom grep flags via env var (#70)

* Use FINAL_GREP_FLAGS for readability
@bubalush
Copy link
Author

bubalush commented Nov 9, 2020

solved

@bubalush bubalush closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants