Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests in Node 12 #729

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Conversation

reecer62
Copy link
Contributor

@reecer62 reecer62 commented Jun 3, 2019

Fixed issue with test where code was being split into multiple lines in util.inspect resulting in invalid syntax. Set compact to true which turned code into one line

(Closes #726)

…in util.inspect resulting in invalid syntax. Set compact to true which turned code into one line
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #729 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #729   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          24     24           
  Lines        1345   1345           
=====================================
  Hits         1345   1345

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f552c4f...77aa844. Read the comment docs.

@kethinov kethinov merged commit 0f53ec1 into rooseveltframework:master Jun 4, 2019
@reecer62 reecer62 deleted the fixTestsNode12 branch June 4, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail in node 12
2 participants