Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix else condition tag mismatch #227

Merged
merged 6 commits into from
Jan 20, 2018
Merged

Conversation

kethinov
Copy link
Member

@kethinov kethinov commented Jan 11, 2018

closes #230

closes #229

closes #226

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.541% when pulling d5f0053 on fix-else-condition-tag-mismatch into 4430a51 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.541% when pulling d5f0053 on fix-else-condition-tag-mismatch into 4430a51 on master.

@kethinov
Copy link
Member Author

@alallier test this out to see if it resolves your issue

Copy link
Member

@alallier alallier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, I found one more problem. Added a new test in my open PR #226. See commit 337d5a5

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 90.572% when pulling 53c06e7 on fix-else-condition-tag-mismatch into 4430a51 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 90.572% when pulling 500bee4 on fix-else-condition-tag-mismatch into 4430a51 on master.

@kethinov kethinov merged commit 7562ade into master Jan 20, 2018
@kethinov kethinov deleted the fix-else-condition-tag-mismatch branch January 20, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants