Fix calling class with service_ensure stopped #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root-expert
requested changes
Feb 28, 2023
There was a problem hiding this comment.
Hello @bparak and thanks for the PR!
Please rebase with master branch since I pushed some commits to fix the CI pipeline.
Using the `snap` provider inside the `snap` class prevents us from using the class to stop `snapd` itself. Since this seems to be sort of supported based on params, this simple conditional fixes the problem.
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
|
Hi @root-expert , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Using the
snapprovider inside thesnapclass prevents us from using the class to stopsnapditself. Since this seems to be sort of supported based on params, this simple conditional fixes the problem.This Pull Request (PR) fixes the following issues
n/a (none open on this repo)