Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] add read-only share-url #430

Closed
tionis opened this issue Apr 11, 2022 · 8 comments
Closed

[Feature Request] add read-only share-url #430

tionis opened this issue Apr 11, 2022 · 8 comments

Comments

@tionis
Copy link

tionis commented Apr 11, 2022

Add a read-only share-url so that each time you generate a share you get a read-only url which only allows listing files and downloading them and a read-write-url which allows changing the share like normal.

@camathieu
Copy link
Member

Hello @tionis,

I think this feature already exists.
When you create an upload you get the UploadToken.
If you pass the token you get read-write rights for this upload if you don't then you will get read only rights.

For example upload a file on plik.root.gg (while not being authenticated). You will be able to add/remove file to the upload but as soon as you refresh the page you'll lose the UploadToken and you will not be able to perform those actions anymore.

If you want to keep the read-write permissions you can use the "Admin URL" button to add the UploadToken to the URL, then refresh the page with this URL and you'll still have the read-write permissions.

image

@tionis
Copy link
Author

tionis commented Apr 30, 2022

I see, do you know which version plik.root.gg runs on?
I'm using the docker container and don't have the token as seen at plik.root.gg

@camathieu
Copy link
Member

It runs a dev build only a few commits behind master at : be8915d (1.3.5+)

https://plik.root.gg/version

@camathieu
Copy link
Member

What version of the docker image are you running ?

The UploadToken feature is really not recent.
Also it's unlikely that it is a web browser issue if it works on plik.root.gg and not on your env.

@tionis
Copy link
Author

tionis commented Apr 30, 2022

Ok, weird I will have to investigate this later, my instance is at https://yeet.digital, I guess we can consider this closed then?

@camathieu
Copy link
Member

I did a test on your instance and it seems to work :)

Read Only :
https://yeet.digital/#/?id=NyO2yQIPzUxIcypV

Read Write :
https://yeet.digital/#/?id=NyO2yQIPzUxIcypV&uploadToken=7gHETjogqZdxaMzr5QlgoImp2OcKimC7

@tionis
Copy link
Author

tionis commented May 10, 2022

Ah yes, it works great, thanks!

@camathieu
Copy link
Member

camathieu commented May 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants