Replace -fvisibility=hidden with C_VISIBILITY_PRESET hidden

Needed for MSVC, since it does not understand -fvisibility=hidden.
root-project · Dec 8, 2018 · b6e12b5 · b6e12b5
1 parent eb84dbc
commit b6e12b5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/builtins/lz4/CMakeLists.txt b/builtins/lz4/CMakeLists.txt
@@ -36,8 +36,7 @@ set(LZ4_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR} CACHE INTERNAL "")
 set(LZ4_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR} CACHE INTERNAL "")
 
 add_library(lz4 STATIC ${LZ4_PUBLIC_HEADERS} ${LZ4_PRIVATE_HEADERS} ${LZ4_SOURCES})
-set_property(TARGET lz4 PROPERTY POSITION_INDEPENDENT_CODE ON)
-target_compile_options(lz4 PRIVATE -fvisibility=hidden)
+set_target_properties(lz4 PROPERTIES C_VISIBILITY_PRESET hidden POSITION_INDEPENDENT_CODE ON)
 target_include_directories(lz4 INTERFACE $<BUILD_INTERFACE:${LZ4_INCLUDE_DIR}>)
 target_link_libraries(lz4 PRIVATE xxHash::xxHash)
 

diff --git a/builtins/xxhash/CMakeLists.txt b/builtins/xxhash/CMakeLists.txt
@@ -17,9 +17,8 @@ set(xxHash_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR} CACHE INTERNAL "")
 set(xxHash_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR} CACHE INTERNAL "")
 
 add_library(xxhash STATIC xxhash.h xxhash.c)
-set_property(TARGET xxhash PROPERTY POSITION_INDEPENDENT_CODE ON)
+set_target_properties(xxhash PROPERTIES C_VISIBILITY_PRESET hidden POSITION_INDEPENDENT_CODE ON)
 target_include_directories(xxhash INTERFACE $<BUILD_INTERFACE:${xxHash_INCLUDE_DIR}>)
-target_compile_options(xxhash PRIVATE -fvisibility=hidden)
 
 add_library(xxHash::xxHash ALIAS xxhash)
 

diff --git a/builtins/zlib/CMakeLists.txt b/builtins/zlib/CMakeLists.txt
@@ -58,9 +58,8 @@ set(ZLIB_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR} CACHE INTERNAL "")
 set(ZLIB_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR} CACHE INTERNAL "")
 
 add_library(ZLIB STATIC ${ZLIB_PUBLIC_HEADERS} ${ZLIB_PRIVATE_HEADERS} ${ZLIB_SOURCES})
-set_property(TARGET ZLIB PROPERTY POSITION_INDEPENDENT_CODE ON) 
+set_target_properties(ZLIB PROPERTIES C_VISIBILITY_PRESET hidden POSITION_INDEPENDENT_CODE ON)
 target_include_directories(ZLIB INTERFACE $<BUILD_INTERFACE:${ZLIB_INCLUDE_DIR}>)
-target_compile_options(ZLIB PRIVATE -fvisibility=hidden)
 
 add_library(ZLIB::ZLIB ALIAS ZLIB)