New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition when loading dictionary shared libraries #12552

Closed

pcanal opened this issue Mar 27, 2023 · 1 comment · Fixed by #12553

Assignees

Labels

bug in:Core Libraries

Projects

Fixed in 6.26/12 Fixed in 6.30/00 Fixed in 6.28/04

Milestone

Member

pcanal commented Mar 27, 2023

As report by @scott-snyder in #11263

Earlier, ATLAS was seeing a nasty race condition involving ROOT dictionary
information (see ATR-25049).

The ROOT internal class TClassTable records information about all classes
that could potentially be created. This is effectively a singleton,
but TClassTable itself does no locking. Rather, it depends on callers
already having acquired the root internal mutex. When a shared library
is loaded that contains dictionary information, TClassTable gets calls
to register information for classes defined in that file. However,
the ROOT lock is not acquired in that case. So a shared library load
could race with TClass::GetClass and result in corruption of TClassTable.

This change modifies TGenericClassInfo::Init so that we will take the lock
when a shared library is loaded.

(ATLAS is currently working around this by hacking shared library loading
in order to acquire the lock, but this hack is not possible with newer
versions of glibc, so this will eventually become a blocker for
moving to centos9.)

See also #11263 (comment)

pcanal added the bug label

pcanal self-assigned this

pcanal added the in:Core Libraries label

pcanal added this to the 6.30/00 milestone

pcanal mentioned this issue

Fix race condition when loading dictionary shared libraries #11263

Closed

pcanal added a commit to pcanal/roottest that referenced this issue


          Test for race condition between dlopen and TClassTClass ops.

4eeed16

This is testing the ROOT issue root-project/root#12552

pcanal mentioned this issue

Test for race condition between dlopen and TClassTable ops. root-project/roottest#946

Merged

pcanal added a commit to pcanal/roottest that referenced this issue


          Test for race condition between dlopen and TClassTable ops.

eee1b30

This is testing the ROOT issue root-project/root#12552

pcanal added a commit to pcanal/root that referenced this issue


          TClassTable: fix data race between dlopen and other use

04af5b6

This fixes root-project#12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

pcanal mentioned this issue

TClassTable: fix data race between dlopen and other uses #12553

Merged

Collaborator

scott-snyder commented Mar 27, 2023

Thanks Philippe!

I'm pretty sure we'll want this in 6.28, and maybe in 6.26 as well.

pcanal added a commit to pcanal/roottest that referenced this issue


          Test for race condition between dlopen and TClassTable ops.

034f53b

This is testing the ROOT issue root-project/root#12552

pcanal added a commit to pcanal/roottest that referenced this issue


          Test for race condition between dlopen and TClassTable ops.

b57558b

This is testing the ROOT issue root-project/root#12552

pcanal added a commit to pcanal/root that referenced this issue


          TClassTable: fix data race between dlopen and other use

6feb1da

This fixes root-project#12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

pcanal added a commit to pcanal/root that referenced this issue


          TClassTable: fix data race between dlopen and other use

1c05509

This fixes root-project#12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

pcanal mentioned this issue

v628: TClassTable: fix data race between dlopen and other uses #12603

Merged

pcanal added a commit to pcanal/root that referenced this issue


          TClassTable: fix data race between dlopen and other use

300a367

This fixes root-project#12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

pcanal added a commit to pcanal/root that referenced this issue


          TClassTable: fix data race between dlopen and other use

513d003

This fixes root-project#12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

pcanal mentioned this issue

[v626] TClassTable: fix data race between dlopen and other uses #12604

Merged

pcanal modified the milestones: 6.30/00, 6.28/04

pcanal added a commit that referenced this issue


          TClassTable: fix data race between dlopen and other use

5b5f205

This fixes #12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

pcanal added a commit to pcanal/root that referenced this issue


          TClassTable: fix data race between dlopen and other use

22ead44

This fixes root-project#12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

pcanal closed this as completed in #12553

pcanal added a commit that referenced this issue


          TClassTable: fix data race between dlopen and other use

154b47d

This fixes #12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

pcanal added a commit to root-project/roottest that referenced this issue


          Test for race condition between dlopen and TClassTable ops.

3186d71

This is testing the ROOT issue root-project/root#12552

pcanal added this to Issues in Fixed in 6.26/12 via automation

pcanal added this to Issues in Fixed in 6.30/00 via automation

pcanal added this to Issues in Fixed in 6.28/04 via automation

pcanal added a commit to pcanal/root that referenced this issue


          TClassTable: fix data race between dlopen and other use

da266a7

This fixes root-project#12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

pcanal added a commit that referenced this issue


          TClassTable: fix data race between dlopen and other use

4a7ac0e

This fixes #12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

enirolf pushed a commit to enirolf/root that referenced this issue


          TClassTable: fix data race between dlopen and other use

dab390a

This fixes root-project#12552

This commit add a mutex for the TClassTable inner operations.
Several changes were needed to insure that operation that can
either take the ROOT global lock or recursively call TClassTable
are executed outside of the TClassTable critical sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment