Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RF] Weighted Datasets for RooKeysPdf including negative weights #12639

Open
MindaugasSarpis opened this issue Apr 11, 2023 · 0 comments
Open

Comments

@MindaugasSarpis
Copy link

Up until now, weights were ignored when computing kernel width in RooKeysPdf.

This was worked on for 6.28, but negative weights are causing evaluation errors (some weights can go negative, like sWeights).

It would be good if negative weights were allowed and cases, where they are not allowed, would throw exceptions rather than computation be attempted.

Relevant forum post:
https://root-forum.cern.ch/t/roofit-keyspdf-fails-in-6-28-works-in-6-26/54440

@guitargeek guitargeek changed the title Weighted Datasets for RooKeysPdf including negative weights [RF] Weighted Datasets for RooKeysPdf including negative weights Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants