Infinite loop in TDirectoryFile::ls

[SilentAssassinMa]

Check duplicate issues.

• Checked for duplicates

Description

In this source file, line 1212, should be a

lnk = lnk->Next()

called before continue, otherwise calling ls with a regex input would cause a dead loop.

Reproducer

non

ROOT version

6.28.04

Installation method

non

Operating system

centos7

Additional context

No response

[jalopezg-git]

Many thanks for reporting the issue, @SilentAssassinMa! I took a quick look and it seems that you are absolutely right.

[ferdymercury]

Could this maybe be a dupe of #8650 ?

[ferdymercury]

Bug probably introduced here: 72a3242

[github-actions]

Hi @pcanal,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖

[jalopezg-git]

I guess #13217 should be backported to 6.28/06, no? @pcanal, will you take care of that or should I?

[pcanal]

@jalopezg-git Yes, can you open a PR?

[jalopezg-git]

@jalopezg-git Yes, can you open a PR?

@ferdymercury as you are the original author of #13217, do you want to take care of the backport?

[ferdymercury]

@jalopezg-git Yes, can you open a PR?

@ferdymercury as you are the original author of #13217, do you want to take care of the backport?

I could do it, but I have never done it before, so I need some guidelines. Should I use rebase on some XY branch and then cherry-picking only my commit or sth like that?

[jalopezg-git]

@jalopezg-git Yes, can you open a PR?

@ferdymercury as you are the original author of #13217, do you want to take care of the backport?

I could do it, but I have never done it before, so I need some guidelines. Should I use rebase on some XY branch and then cherry-picking only my commit or sth like that?

Assuming that the remote origin refers to upstream and ferdymercury to https://github.com/ferdymercury/root/, the simplest way is to

$ git fetch origin v6-28-00-patches:v6-28-00-patches
$ git checkout -b TDirectoryFile-ls-v6.28 v6-28-00-patches
$ git cherry-pick ... # your commit(s) here - I think it was 2 commits; mention them in order here
$ git push ferdymercury TDirectoryFile-ls-v6.28

, and then open a PR to be merged against the v6-28-00-patches branch. I'll let you try; if you don't manage, I'll do it instead 🙂.

[ferdymercury]

I did: (note to self)
Thanks for the help!

git clone git@github.com:root-project/root
cd root
git remote add ferdymercury git@github.com:/ferdymercury/root
git remote -v
ferdymercury	git@github.com:ferdymercury/root.git (fetch)
ferdymercury	git@github.com:ferdymercury/root.git (push)
origin	git@github.com:root-project/root (fetch)
origin	git@github.com:root-project/root (push)
git fetch origin v6-28-00-patches:v6-28-00-patches
git checkout -b TDirectoryFile-ls-v6.28 v6-28-00-patches
git config user.name "ferdymercury"
git config user.email "ferdymercury@users.noreply.github.com"
git cherry-pick 18c847267b8651b7b392116767c5671f14c1c46e cb08bb7445a0b8db0a64a505399844c85ed048a4
git push ferdymercury TDirectoryFile-ls-v6.28