Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSVC] ROOT builds under msvc option /permissive- with error C4576 #13421

Closed
1 task done
Zhaojun-Liu opened this issue Aug 9, 2023 · 0 comments
Closed
1 task done
Assignees
Labels

Comments

@Zhaojun-Liu
Copy link

Check duplicate issues.

  • Checked for duplicates

Description

Hi:
I build ROOT on Windows with msvc and with option /permissive-, it issues error like below, could you take a look at this issue, thanks.
F:\gitP\root-project\root\tmva\tmva\inc\TMVA/RBatchGenerator.hxx(100,89): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax [F:\gitP\root-project\root\build_amd64\tmva\tmva\G__TMVA.vcxproj]

Workaround:
If I remove the brackets around the std::vector<std::size_t> in the line: https://github.com/root-project/root/blob/master/tmva/tmva/inc/TMVA/RBatchGenerator.hxx#L100, error will disappear.

Reproducer

Open a VS2022 x64 Native Tools command.

  1. git clone https://github.com/root-project/root F:\gitP\root-project\root
  2. git -C "F:\gitP\root-project\root" reset --hard 0d1f204
  3. mkdir F:\gitP\root-project\root\build_amd64 and cd F:\gitP\root-project\root\build_amd64
  4. python.exe -m pip install pytest
  5. set CL=/permissive-
  6. cmake -G "Visual Studio 17 2022" -A x64 -DCMAKE_SYSTEM_VERSION=10.0.22621.0 -DCMAKE_BUILD_TYPE=Release -Droofit=off -Dtesting=ON -Droottest=ON ..
  7. msbuild /m /p:Platform=x64 /p:Configuration=Release ALL_BUILD.vcxproj /t:Rebuild

ROOT version

commit: 0d1f204

Installation method

build from source

Operating system

Windows

Additional context

build.log

@Zhaojun-Liu Zhaojun-Liu added the bug label Aug 9, 2023
bellenot added a commit to bellenot/root that referenced this issue Dec 20, 2023
@bellenot bellenot added this to Issues in Fixed in 6.32.00 via automation Dec 21, 2023
maksgraczyk pushed a commit to maksgraczyk/root that referenced this issue Jan 12, 2024
* Remove unnecessary cast. This should fix root-project#13421

* Removed too much
vgvassilev pushed a commit to vgvassilev/root that referenced this issue Feb 8, 2024
* Remove unnecessary cast. This should fix root-project#13421

* Removed too much
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

3 participants