Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootprint missing recursive traversal #13659

Open
ferdymercury opened this issue Sep 18, 2023 · 1 comment · May be fixed by #14419
Open

rootprint missing recursive traversal #13659

ferdymercury opened this issue Sep 18, 2023 · 1 comment · May be fixed by #14419
Assignees

Comments

@ferdymercury
Copy link
Collaborator

ferdymercury commented Sep 18, 2023

Explain what you would like to see improved and how.

rootprint does not output canvases that are stored inside a subdirectory.

The CLI should accept a 'recursive' parameter that allows to deal with these cases

Additional context

https://root-forum.cern.ch/t/saving-all-plots-from-a-root-file-into-separate-png-files/56379/3?u=ferhue

@couet
Copy link
Member

couet commented Sep 26, 2023

The code is in $ROOTSYS/main/python/cmdLineUtils.py at line 1394. The function retrieving the list of objects to be printed is:

def _keyListExtended(rootFile,pathSplitList):
    keyList,dirList = keyClassSpliter(rootFile,pathSplitList)
    for pathSplit in dirList: keyList.extend(getKeyList(rootFile,pathSplit))
    keyList = [key for key in keyList if not isDirectoryKey(key)]
    keyListSort(keyList)
    return keyList

Somehow it should be extended in order to scan sub-directories.

ferdymercury added a commit to ferdymercury/root that referenced this issue Jan 24, 2024
@ferdymercury ferdymercury linked a pull request Jan 24, 2024 that will close this issue
2 tasks
ferdymercury added a commit to ferdymercury/root that referenced this issue Apr 9, 2024
Fixes root-project#13659

Apply suggestions from code review

thanks guitargeek!

Co-authored-by: Jonas Rembser <jonas.rembser@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants