-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected behaviour of KSTest with toys ("X" option) for identical histograms #13697
Comments
The problem is that one of the histogram is having all bin errors equal to zero. Is this intentional ? |
…ro errors Fix the case of using KS test when one of the histogram has zero errors (i.e is a function). Improve KS test adding possibility to specify number of toys by using option "X=number" for example "X=1000" This fixes the issue root-project#13697
…ero errors Fix the case of using KS test when one of the histogram has zero errors (i.e is a function). Improve KS test adding possibility to specify number of toys by using option "X=number" for example "X=1000" This fixes the issue root-project#13697
Hi, thanks for the reply, indeed, in this case the histograms do have 0 uncertainties. I was just surprised by the 0 probability. I think an error message would help, thanks! |
…ero errors Fix the case of using KS test when one of the histogram has zero errors (i.e is a function). Improve KS test adding possibility to specify number of toys by using option "X=number" for example "X=1000" This fixes the issue root-project#13697
…ero errors Fix the case of using KS test when one of the histogram has zero errors (i.e is a function). Improve KS test adding possibility to specify number of toys by using option "X=number" for example "X=1000" This fixes the issue #13697
…ero errors Fix the case of using KS test when one of the histogram has zero errors (i.e is a function). Improve KS test adding possibility to specify number of toys by using option "X=number" for example "X=1000" This fixes the issue root-project#13697
…ero errors Fix the case of using KS test when one of the histogram has zero errors (i.e is a function). Improve KS test adding possibility to specify number of toys by using option "X=number" for example "X=1000" This fixes the issue #13697
…ero errors Fix the case of using KS test when one of the histogram has zero errors (i.e is a function). Improve KS test adding possibility to specify number of toys by using option "X=number" for example "X=1000" This fixes the issue root-project#13697
Check duplicate issues.
Description
When passing some identical histograms to KSTest of TH1, the code return probability 0 in case of the "X" option (runing toys) while the probablity of the default KS test is 1 (as expected).
Reproducer
running the following macro reproduces the issue:
with the input file available in this public afs repository: /afs/cern.ch/user/t/tdado/public/kstest.root
I could not reproduce it with a dummy histograms, so it must be somehow related to the actual values in the bins?
ROOT version
ROOT Version: 6.28/04
Built for linuxx8664gcc on Jul 10 2023, 18:22:00
From v6-28-04@v6-28-04
Installation method
source from LCG
Operating system
CentOS7 (lxplus)
Additional context
No response
The text was updated successfully, but these errors were encountered: