Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial fit/fit2dHist.C crashed when running with global combined fit #13906

Closed
1 task done
linev opened this issue Oct 20, 2023 · 1 comment · Fixed by #13928
Closed
1 task done

Tutorial fit/fit2dHist.C crashed when running with global combined fit #13906

linev opened this issue Oct 20, 2023 · 1 comment · Fixed by #13928
Assignees
@lmoneta
Labels
affects:master affects:6.30 bug in:Math Libraries
Projects
Fixed in 6.30/00

Comments

@linev
Copy link
Member

linev commented Oct 20, 2023

Check duplicate issues.

  • Checked for duplicates

Description

Tutorial macro crashes when running:

 root -l "tutorials/fit/fit2dHist.C(11)"

Reproducer

Produces output:

Processing tutorials/fit/fit2dHist.C(11)...
Do global fit
Error in <ROOT::Math::Fitter::SetFCN>: wrong fit parameter settings
terminate called after throwing an instance of 'std::out_of_range'
  what():  vector::_M_range_check: __n (which is 0) >= this->size() (which is 0)

ROOT version

master

Installation method

build from source

Operating system

OpenSUSE Linux

Additional context

No response
lmoneta added a commit to lmoneta/root that referenced this issue Oct 24, 2023
@lmoneta
[mathcore] Fix creating the ParameterSetting when calling SetFCN
78fbd71 
This fixes using the fit2dHist.C when using the global fit (user defined FCN)

This PR fixes root-project#13906
@lmoneta lmoneta mentioned this issue Oct 24, 2023
Merged
lmoneta added a commit that referenced this issue Oct 26, 2023
@lmoneta
[mathcore] Fix creating the ParameterSetting when calling SetFCN
b0fd025 
This fixes using the fit2dHist.C when using the global fit (user defined FCN)

This PR fixes #13906
lmoneta added a commit to lmoneta/root that referenced this issue Oct 26, 2023
@lmoneta
[mathcore] Fix creating the ParameterSetting when calling SetFCN
aba1f9e 
This fixes using the fit2dHist.C when using the global fit (user defined FCN)

This PR fixes root-project#13906
@lmoneta lmoneta mentioned this issue Oct 26, 2023
Merged
@github-actions
Copy link

Hi @lmoneta,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖

@linev linev added this to Issues in Fixed in 6.30/00 via automation Oct 27, 2023
lmoneta added a commit that referenced this issue Oct 27, 2023
@lmoneta
[mathcore] Fix creating the ParameterSetting when calling SetFCN
b1b1f89 
This fixes using the fit2dHist.C when using the global fit (user defined FCN)

This PR fixes #13906
maksgraczyk pushed a commit to maksgraczyk/root that referenced this issue Jan 12, 2024
@lmoneta @maksgraczyk
[mathcore] Fix creating the ParameterSetting when calling SetFCN
5c603b8 
This fixes using the fit2dHist.C when using the global fit (user defined FCN)

This PR fixes root-project#13906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmoneta lmoneta

Labels
affects:master affects:6.30 bug in:Math Libraries
Projects
No open projects
Fixed in 6.30/00
Issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mathcore] Fix creating the ParameterSetting when calling SetFCN lmoneta/root
2 participants
@linev @lmoneta