Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hadd --help prints wrong usage info #6438

Closed
eguiraud opened this issue Sep 24, 2020 · 2 comments
Closed

hadd --help prints wrong usage info #6438

eguiraud opened this issue Sep 24, 2020 · 2 comments

Comments

@eguiraud
Copy link
Member

Describe the bug

hadd --help prints the following:

usage: hadd [-a A] [-k K] [-T T] [-O O] [-v V] [-j J] [-dbg DBG] [-d D] [-n N]
            [-cachesize CACHESIZE]
            [-experimental-io-features EXPERIMENTAL_IO_FEATURES] [-f F]
            [-fk FK] [-ff FF] [-f0 F0] [-f6 F6]
            TARGET SOURCES

OPTIONS:
  -a                                   Append to the output
  -k                                   Skip corrupt or non-existent files, do not exit
  -T                                   Do not merge Trees
  -O                                   Re-optimize basket size when merging TTree
  -v                                   Explicitly set the verbosity level: 0 request no output, 99 is the default
  -j                                   Parallelize the execution in multiple processes
  -dbg                                 Parallelize the execution in multiple processes in debug mode (Does not delete partial files stored inside working directory)
  -d                                   Carry out the partial multiprocess execution in the specified directory
  -n                                   Open at most 'maxopenedfiles' at once (use 0 to request to use the system maximum)
  -cachesize                           Resize the prefetching cache use to speed up I/O operations(use 0 to disable)
  -experimental-io-features            Used with an argument provided, enables the corresponding experimental feature for output trees
  -f                                   Gives the ability to specify the compression level of the target file(by default 4) 
  -fk                                  Sets the target file to contain the baskets with the same compression
                                       as the input files (unless -O is specified). Compresses the meta data
                                       using the compression level specified in the first input or the
                                       compression setting after fk (for example 206 when using -fk206)
  -ff                                  The compression level use is the one specified in the first input
  -f0                                  Do not compress the target file
  -f6                                  Use compression level 6. (See TFile::SetCompressionSettings for the support range of value.)
  TARGET                               Target file
  SOURCES                              Source files

The options -fk, -ff and -f0 are listed in the short usage overview as [-fk FK] [-ff FF] [-f0 F0] , but they do not accept a parameter.

The docs mention that -f controls the compression level of the target file (e.g. 4), but it's actually possible to specify the full compressoin algorithm (e.g. 404).

@github-actions github-actions bot added this to Needs triage in Triage Sep 24, 2020
@oshadura
Copy link
Contributor

I think I can pick up @pcanal?

@pcanal
Copy link
Member

pcanal commented Sep 25, 2020

Thanks.

@eguiraud eguiraud moved this from Needs triage to Rest in Triage Oct 6, 2020
@oshadura oshadura assigned pcanal and oshadura and unassigned oshadura Jul 14, 2021
ferdymercury added a commit to ferdymercury/root that referenced this issue May 18, 2023
ferdymercury added a commit to ferdymercury/root that referenced this issue Aug 1, 2023
Fixes root-project#6438

fix outdated max compression level
do not error when asking help
missing -T option
reorder options
whitespace fix, missing full stop
clarify file open n max
mention cachesize in docs
avoid repeated compression docu
specify compression algorithm
Clarify meaning of dbg and j
mention where to look for compression algorithm
ferdymercury added a commit to ferdymercury/root that referenced this issue Sep 19, 2023
Fixes root-project#6438

fix outdated max compression level
do not error when asking help
missing -T option
reorder options
whitespace fix, missing full stop
clarify file open n max
mention cachesize in docs
avoid repeated compression docu
specify compression algorithm
Clarify meaning of dbg and j
mention where to look for compression algorithm
ferdymercury added a commit to ferdymercury/root that referenced this issue Sep 19, 2023
Fixes root-project#6438

fix outdated max compression level
do not error when asking help
missing -T option
reorder options
whitespace fix, missing full stop
clarify file open n max
mention cachesize in docs
avoid repeated compression docu
specify compression algorithm
Clarify meaning of dbg and j
mention where to look for compression algorithm
ferdymercury added a commit to ferdymercury/root that referenced this issue Sep 19, 2023
Fixes root-project#6438

fix outdated max compression level
do not error when asking help
missing -T option
reorder options
whitespace fix, missing full stop
clarify file open n max
mention cachesize in docs
avoid repeated compression docu
specify compression algorithm
Clarify meaning of dbg and j
mention where to look for compression algorithm
ferdymercury added a commit to ferdymercury/root that referenced this issue Sep 19, 2023
Fixes root-project#6438

fix outdated max compression level
do not error when asking help
missing -T option
reorder options
whitespace fix, missing full stop
clarify file open n max
mention cachesize in docs
avoid repeated compression docu
specify compression algorithm
Clarify meaning of dbg and j
mention where to look for compression algorithm
@vepadulano vepadulano added this to Issues in Fixed in 6.32.00 via automation Oct 18, 2023
maksgraczyk pushed a commit to maksgraczyk/root that referenced this issue Jan 12, 2024
Fixes root-project#6438

fix outdated max compression level
do not error when asking help
missing -T option
reorder options
whitespace fix, missing full stop
clarify file open n max
mention cachesize in docs
avoid repeated compression docu
specify compression algorithm
Clarify meaning of dbg and j
mention where to look for compression algorithm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants