-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pass Bearer token authentication header to Davix client #6802
Comments
@dciangot Could you submit your proposal as a draft PR? To me it makes sense and I think we should discuss necessary changes as part of the PR review. |
@dciangot And: thanks a lot for submitting the issue together with a patch! That's very much appreciated! |
Thank a lot @oshadura |
@oshadura I confirm that is perfectly fine for us. Thank you! |
Actually, I tested only the token in the environment variable. In fact, trying out the token-in-file way, I get this error (*), any idea @oshadura ? (*) |
@dciangot ha, thanks for the report! I am looking into it... |
@dciangot I forgot to ask, I will not be able to access the file in your mini reproducer?
|
Yeah, unfortunately you won't :/ |
@dciangot Can you try please meanwhile access file exporting |
@oshadura that was the first test I didi actually, and it's working perfectly. |
@dciangot sorry, I fixed a small typo and now I see that it will not crash anymore for your setup (I am getting "Server certificate verification failed: issuer is not trusted after 3 attempts", but it was expected?):
|
Is your feature request related to a problem? Please describe.
If I want to read data from a webDav/http endpoint using an oidc token, I'd need to be able to pass the token somehow in ROOT to the Davix client wrapper. Possibly through env variable and rootrc.
Describe the solution you'd like
Make the Davix client wrapper able to take the token from env variable and rootrc.
Additional context
Preparatory for future WLCG (and not only) authN/Z model.
I was thinking to something like this as a required change, but, of course, I'd need more feedback: https://github.com/root-project/root/compare/master...dciangot:davix_bearer_token?expand=1
The text was updated successfully, but these errors were encountered: