Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdf.Snapshot columnList - automate size columns #6932

Closed
andrzejnovak opened this issue Dec 8, 2020 · 2 comments
Closed

rdf.Snapshot columnList - automate size columns #6932

andrzejnovak opened this issue Dec 8, 2020 · 2 comments

Comments

@andrzejnovak
Copy link

Could rdf.Snapshot figure out which columns it needs for the sizing information and include them automatically? I am assuming since rdf is probably agnostic about the actual branch naming scheme there is some underlying info in the branches that lets rdf identify which one is which anyway (e.g. two different sized collections).

@github-actions github-actions bot added this to Needs triage in Triage Dec 8, 2020
@eguiraud eguiraud self-assigned this Dec 9, 2020
@eguiraud eguiraud removed this from Needs triage in Triage Dec 9, 2020
@eguiraud
Copy link
Member

eguiraud commented Dec 9, 2020

Fair suggestion, thanks! This is fairly tricky to implement because, in general, we want to know the column types at compile-time, but the information about the type of a potential "size branch" is only known at runtime (i.e. when opening the file). So there is little hope to make this work for Snapshot<coltype1, coltype2, coltype3>(...).

For a just-in-time-compiled call, i.e. Snapshot(...), we could add some logic here:

RResultPtr<RInterface<RLoopManager>> Snapshot(std::string_view treename, std::string_view filename,

to inspect the input columns, and if they are a branch check if they have an associated size branch and also add that one to the column list.

eguiraud added a commit to eguiraud/root that referenced this issue Jul 8, 2022
eguiraud added a commit to eguiraud/root that referenced this issue Jul 8, 2022
eguiraud added a commit to eguiraud/root that referenced this issue Jul 20, 2022
eguiraud added a commit to eguiraud/root that referenced this issue Jul 22, 2022
eguiraud added a commit that referenced this issue Jul 24, 2022
eguiraud added a commit that referenced this issue Jul 24, 2022
@eguiraud
Copy link
Member

This is fixed in master and v6-26-00-patches (aka the upcoming v6.26.06) for the case of a jitted Snapshot call (i.e. when no template parameters are specified, so the most common case). @andrzejnovak please let us know if you still have issues with the current master branch or that release.

@eguiraud eguiraud added this to Issues in Fixed in 6.26/06 via automation Jul 24, 2022
j-mathe pushed a commit to j-mathe/root that referenced this issue Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants