TGSpeedo mean value calculation #7164
Comments
bellenot
added a commit
to bellenot/root
that referenced
this issue
Feb 10, 2021
…ct#7164) Add a very simple circular buffer allowing to automatically compute and display the mean of last N values when enabling the mean mark with `EnableMeanMark()`. The size of the buffer can be changed with `SetBufferSize()`. Thanks to @ferdymercury for the suggestion
|
@ferdymercury FYI, a Pull Request has been created |
ferdymercury
added a commit
to ferdymercury/root
that referenced
this issue
Feb 10, 2021
bellenot
added a commit
that referenced
this issue
Feb 15, 2021
) * Add a circular buffer to compute the mean value (fix issue #7164) Add a very simple circular buffer allowing to automatically compute and display the mean of last N values when enabling the mean mark with `EnableMeanMark()`. The size of the buffer can be changed with `SetBufferSize()`. Thanks to @ferdymercury for the suggestion * Fix typo (thanks @ferdymercury) * Preserve backward compatibility (thanks @ferdymercury) * Better (more precise) mean calculation * properly prevent int overflows * Fix warning: comparison of integer expressions of different signedness * Apply changes from @ferdymercury * Update gui/gui/src/TGSpeedo.cxx Co-authored-by: Enrico Guiraud <enrico.guiraud@cern.ch> * Address some of the @eguiraud comments - Add some explanation about how to use the circular buffer and how it works - Protect against negative argument given for the buffer size - Remove an unecessary cast to float Co-authored-by: Enrico Guiraud <enrico.guiraud@cern.ch>
|
Fixed by #7170 |
nicknagi
pushed a commit
to nicknagi/root
that referenced
this issue
Mar 30, 2021
…ct#7164) (root-project#7170) * Add a circular buffer to compute the mean value (fix issue root-project#7164) Add a very simple circular buffer allowing to automatically compute and display the mean of last N values when enabling the mean mark with `EnableMeanMark()`. The size of the buffer can be changed with `SetBufferSize()`. Thanks to @ferdymercury for the suggestion * Fix typo (thanks @ferdymercury) * Preserve backward compatibility (thanks @ferdymercury) * Better (more precise) mean calculation * properly prevent int overflows * Fix warning: comparison of integer expressions of different signedness * Apply changes from @ferdymercury * Update gui/gui/src/TGSpeedo.cxx Co-authored-by: Enrico Guiraud <enrico.guiraud@cern.ch> * Address some of the @eguiraud comments - Add some explanation about how to use the circular buffer and how it works - Protect against negative argument given for the buffer size - Remove an unecessary cast to float Co-authored-by: Enrico Guiraud <enrico.guiraud@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Explain what you would like to see improved
TGSpeedo class is quite helpful, but it lacks the ability of auto-calculating the mean value (a mean mark is there, but is up to the user to put a senseful value there on each update).
Optional: share how it could be improved
I would propose to let the user define a circular buffer size, so that the TGSpeedo class autocalculates the mean value of the last N entries. The default value would be N=0 to keep old behaviour and save memory, but the user could call for example SetMeanBufferSize(10) to do an average of the last 10 entries.
Could be implemented for example using https://root.cern/doc/master/circular_8C.html
or just with this simple header class: https://github.com/jnk0le/Ring-Buffer/blob/master/ringbuffer.hpp
And then the average just as
std::sum(begin(...), end(...), 0)/NTo Reproduce
Setup
The text was updated successfully, but these errors were encountered: