Trailing dot dropped in top level branch name #7281
Assignees
Projects
Milestone
Comments
pcanal
added a commit
to pcanal/root
that referenced
this issue
Apr 13, 2021
The intent was to prevent the creation of sub branch with 2 consecutives dots and to avoid a dot between the branch name of the collection and the underscore for name of the index leaf. The major problem of the first try is that the name of the top level branch was changed from "t." to "t" making existing code search for the branch by fullname failing. Fix root-project#7281 This effectively ammends/corrects d225f94 Before v6.23 ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485042 bytes File Size = 177202 * * : : Tree compression factor = 2.74 * ****************************************************************************** *Br 0 :t. : Int_t t._ * *Entries : 10000 : Total Size= 83464 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t..fUniqueID : UInt_t fUniqueID[t._] * *Entries : 10000 : Total Size= 80935 bytes File Size = 12857 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t..fBits : UInt_t fBits[t._] * *Entries : 10000 : Total Size= 80903 bytes File Size = 12879 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t..e : Double_t e[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 65937 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.83 * *............................................................................* *Br 4 :t..t : Double_t t[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 71633 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* After the first try: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 484998 bytes File Size = 177400 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t : Int_t t_ * *Entries : 10000 : Total Size= 83438 bytes File Size = 12838 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.26 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* Now: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485003 bytes File Size = 177402 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t. : Int_t t_ * *Entries : 10000 : Total Size= 83444 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................*
pcanal
added a commit
to pcanal/root
that referenced
this issue
Apr 13, 2021
The intent was to prevent the creation of sub branch with 2 consecutives dots and to avoid a dot between the branch name of the collection and the underscore for name of the index leaf. The major problem of the first try is that the name of the top level branch was changed from "t." to "t" making existing code search for the branch by fullname failing. Fix root-project#7281 This effectively ammends/corrects d225f94 Before v6.23 ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485042 bytes File Size = 177202 * * : : Tree compression factor = 2.74 * ****************************************************************************** *Br 0 :t. : Int_t t._ * *Entries : 10000 : Total Size= 83464 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t..fUniqueID : UInt_t fUniqueID[t._] * *Entries : 10000 : Total Size= 80935 bytes File Size = 12857 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t..fBits : UInt_t fBits[t._] * *Entries : 10000 : Total Size= 80903 bytes File Size = 12879 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t..e : Double_t e[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 65937 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.83 * *............................................................................* *Br 4 :t..t : Double_t t[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 71633 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* After the first try: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 484998 bytes File Size = 177400 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t : Int_t t_ * *Entries : 10000 : Total Size= 83438 bytes File Size = 12838 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.26 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* Now: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485003 bytes File Size = 177402 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t. : Int_t t_ * *Entries : 10000 : Total Size= 83444 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................*
pcanal
added a commit
to pcanal/root
that referenced
this issue
Apr 13, 2021
The intent was to prevent the creation of sub branch with 2 consecutives dots and to avoid a dot between the branch name of the collection and the underscore for name of the index leaf. The major problem of the first try is that the name of the top level branch was changed from "t." to "t" making existing code search for the branch by fullname failing. Fix root-project#7281 This effectively ammends/corrects d225f94 Before v6.23 ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485042 bytes File Size = 177202 * * : : Tree compression factor = 2.74 * ****************************************************************************** *Br 0 :t. : Int_t t._ * *Entries : 10000 : Total Size= 83464 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t..fUniqueID : UInt_t fUniqueID[t._] * *Entries : 10000 : Total Size= 80935 bytes File Size = 12857 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t..fBits : UInt_t fBits[t._] * *Entries : 10000 : Total Size= 80903 bytes File Size = 12879 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t..e : Double_t e[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 65937 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.83 * *............................................................................* *Br 4 :t..t : Double_t t[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 71633 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* After the first try: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 484998 bytes File Size = 177400 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t : Int_t t_ * *Entries : 10000 : Total Size= 83438 bytes File Size = 12838 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.26 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* Now: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485003 bytes File Size = 177402 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t. : Int_t t_ * *Entries : 10000 : Total Size= 83444 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................*
Axel-Naumann
pushed a commit
that referenced
this issue
Apr 13, 2021
The intent was to prevent the creation of sub branch with 2 consecutives dots and to avoid a dot between the branch name of the collection and the underscore for name of the index leaf. The major problem of the first try is that the name of the top level branch was changed from "t." to "t" making existing code search for the branch by fullname failing. Fix #7281 This effectively ammends/corrects d225f94 Before v6.23 ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485042 bytes File Size = 177202 * * : : Tree compression factor = 2.74 * ****************************************************************************** *Br 0 :t. : Int_t t._ * *Entries : 10000 : Total Size= 83464 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t..fUniqueID : UInt_t fUniqueID[t._] * *Entries : 10000 : Total Size= 80935 bytes File Size = 12857 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t..fBits : UInt_t fBits[t._] * *Entries : 10000 : Total Size= 80903 bytes File Size = 12879 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t..e : Double_t e[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 65937 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.83 * *............................................................................* *Br 4 :t..t : Double_t t[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 71633 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* After the first try: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 484998 bytes File Size = 177400 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t : Int_t t_ * *Entries : 10000 : Total Size= 83438 bytes File Size = 12838 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.26 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* Now: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485003 bytes File Size = 177402 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t. : Int_t t_ * *Entries : 10000 : Total Size= 83444 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................*
|
Hi, please add a "fixed in" project to this issue |
|
A a side note, the "fixed in" is a bit misleading here ... because the bug does not exist in any tagged version :) |
pcanal
added a commit
to pcanal/root
that referenced
this issue
Apr 13, 2021
The intent was to prevent the creation of sub branch with 2 consecutives dots and to avoid a dot between the branch name of the collection and the underscore for name of the index leaf. The major problem of the first try is that the name of the top level branch was changed from "t." to "t" making existing code search for the branch by fullname failing. Fix root-project#7281 This effectively ammends/corrects d225f94 Before v6.23 ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485042 bytes File Size = 177202 * * : : Tree compression factor = 2.74 * ****************************************************************************** *Br 0 :t. : Int_t t._ * *Entries : 10000 : Total Size= 83464 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t..fUniqueID : UInt_t fUniqueID[t._] * *Entries : 10000 : Total Size= 80935 bytes File Size = 12857 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t..fBits : UInt_t fBits[t._] * *Entries : 10000 : Total Size= 80903 bytes File Size = 12879 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t..e : Double_t e[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 65937 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.83 * *............................................................................* *Br 4 :t..t : Double_t t[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 71633 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* After the first try: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 484998 bytes File Size = 177400 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t : Int_t t_ * *Entries : 10000 : Total Size= 83438 bytes File Size = 12838 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.26 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* Now: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485003 bytes File Size = 177402 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t. : Int_t t_ * *Entries : 10000 : Total Size= 83444 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................*
pcanal
added a commit
to pcanal/root
that referenced
this issue
Apr 13, 2021
The intent was to prevent the creation of sub branch with 2 consecutives dots and to avoid a dot between the branch name of the collection and the underscore for name of the index leaf. The major problem of the first try is that the name of the top level branch was changed from "t." to "t" making existing code search for the branch by fullname failing. Fix root-project#7281 This effectively ammends/corrects d225f94 Before v6.23 ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485042 bytes File Size = 177202 * * : : Tree compression factor = 2.74 * ****************************************************************************** *Br 0 :t. : Int_t t._ * *Entries : 10000 : Total Size= 83464 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t..fUniqueID : UInt_t fUniqueID[t._] * *Entries : 10000 : Total Size= 80935 bytes File Size = 12857 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t..fBits : UInt_t fBits[t._] * *Entries : 10000 : Total Size= 80903 bytes File Size = 12879 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t..e : Double_t e[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 65937 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.83 * *............................................................................* *Br 4 :t..t : Double_t t[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 71633 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* After the first try: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 484998 bytes File Size = 177400 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t : Int_t t_ * *Entries : 10000 : Total Size= 83438 bytes File Size = 12838 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.26 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* Now: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485003 bytes File Size = 177402 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t. : Int_t t_ * *Entries : 10000 : Total Size= 83444 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................*
Axel-Naumann
pushed a commit
that referenced
this issue
Apr 15, 2021
The intent was to prevent the creation of sub branch with 2 consecutives dots and to avoid a dot between the branch name of the collection and the underscore for name of the index leaf. The major problem of the first try is that the name of the top level branch was changed from "t." to "t" making existing code search for the branch by fullname failing. Fix #7281 This effectively ammends/corrects d225f94 Before v6.23 ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485042 bytes File Size = 177202 * * : : Tree compression factor = 2.74 * ****************************************************************************** *Br 0 :t. : Int_t t._ * *Entries : 10000 : Total Size= 83464 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t..fUniqueID : UInt_t fUniqueID[t._] * *Entries : 10000 : Total Size= 80935 bytes File Size = 12857 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t..fBits : UInt_t fBits[t._] * *Entries : 10000 : Total Size= 80903 bytes File Size = 12879 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t..e : Double_t e[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 65937 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.83 * *............................................................................* *Br 4 :t..t : Double_t t[t._] * *Entries : 10000 : Total Size= 121029 bytes File Size = 71633 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* After the first try: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 484998 bytes File Size = 177400 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t : Int_t t_ * *Entries : 10000 : Total Size= 83438 bytes File Size = 12838 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.26 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................* Now: ****************************************************************************** *Tree :tree : treelibrated tree * *Entries : 10000 : Total = 485003 bytes File Size = 177402 * * : : Tree compression factor = 2.73 * ****************************************************************************** *Br 0 :t. : Int_t t_ * *Entries : 10000 : Total Size= 83444 bytes File Size = 12844 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 1 :t.fUniqueID : UInt_t fUniqueID[t_] * *Entries : 10000 : Total Size= 80925 bytes File Size = 12852 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.25 * *............................................................................* *Br 2 :t.fBits : UInt_t fBits[t_] * *Entries : 10000 : Total Size= 80893 bytes File Size = 12869 * *Baskets : 4 : Basket Size= 32000 bytes Compression= 6.24 * *............................................................................* *Br 3 :t.e : Double_t e[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 66198 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.82 * *............................................................................* *Br 4 :t.t : Double_t t[t_] * *Entries : 10000 : Total Size= 121017 bytes File Size = 71609 * *Baskets : 6 : Basket Size= 32000 bytes Compression= 1.68 * *............................................................................*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See https://root-forum.cern.ch/t/root-6-23-changing-name-of-branch-with-tclonesarray/43626/4
A recent change to improve GetBranch's behavior lead to an improvement of the sub-branch name but also (inadvertently?) to a change of the top level name. We need to either confirm that we want to change or revert the top level name part.
The text was updated successfully, but these errors were encountered: