Integer overflow in TTreeCache::FillBuffer

[SilentAssassinMa]

Describe the bug

The TTree::SetCacheSize() method takes 64-byte integer as input, however the types of member fBuffer and fBufferMin in class TTreeCache are both 32-byte integer, so there will be an integer overflow if one tries to set the buffer size more than 512MB because in the line 1614 of TTreeCache.cxx:

if (ntotCurrentBuf > 4 * fBufferSizeMin) 
// Humm something wrong happened.
                  Warning("FillBuffer", "There is more data in this cluster (starting at entry %lld to %lld, "
                                        "current=%lld) than usual ... with %d %.3f%% of the branches we already have "
                                        "%d bytes (instead of %d)",
                          fEntryCurrent, fEntryNext, entries[j], i, (100.0 * i) / ((float)fNbranches), ntotCurrentBuf,
                          fBufferSizeMin);

so one will get weird warnings like:

Warning in <TTreeCache::FillBuffer>: There is more data in this cluster (starting at entry 0 to 34020, current=31185) than usual ... with 700 42.067% of the branches we already have 458967692 bytes (instead of 1073741824)

even though every thing is fine.

[ferdymercury]

I proposed a PR

[github-actions]

Hi @pcanal,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely,
🤖