[tree] Fix GetTreeFullPaths in case of protocol://
#10217
Conversation
|
Starting build on |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Failing tests: |
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
|
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
GetTreeFullPaths assumed that the first occurrence of ":/" was the separator between filename and tree name in strings such as "file.root:/dir/tree". However, the separator is the _last_ occurrence of ":/" -- e.g. if the file is read via a remote protocol, its name starts with "protocol://". This logic is of course still broken in case the name of the tree or the one of the directory that contains it contains ":/", we do not support that case. This fixes root-project#10216.
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/soversion. |
|
Hi @eguiraud I see similar behavior to this issue when using TTreeProcessorMT on xrootd-streamed files when using ROOT 6.22/08. Just wanted to check that this fix will also work for my issue before we try integrating >= 6.28/00 into our workflow. Edit: sorry for bumping such an old thread btw |
GetTreeFullPaths assumed that the first occurrence of ":/" was
the separator between filename and tree name in strings such as
"file.root:/dir/tree". However, the separator is the last
occurrence of ":/" -- e.g. if the file is read via a remote
protocol, its name starts with "protocol://".
This logic is of course still broken in case the name of the tree
or the one of the directory that contains it contains ":/", we
do not support that case.
This fixes #10216.